chore(commitlint): simplify config to conventional preset only#237
chore(commitlint): simplify config to conventional preset only#237froggy1014 merged 2 commits intodev/side-v2from
Conversation
Remove custom rules (english-only, subject-max-length, scope-max-length), plugins, and UserConfig typing. Upgrade @commitlint packages to v20 and add inquirer@9 peer dependency.
froggy1014
requested review from
3o14,
G-hoon,
KYBee,
Yeom-JinHo,
haedawn,
minjeeki,
minji0214 and
osohyun0224
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
| rules: { | ||
| 'subject-english-only': ({ subject }) => { | ||
| if (!subject) return [true, '']; | ||
| const valid = englishOnly.test(subject); |
There was a problem hiding this comment.
Now we're free haha
🪦 RIP subject-english-only
| // https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional | ||
| // | ||
| // @commitlint/config-conventional 허용 타입: | ||
| // build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test |
There was a problem hiding this comment.
Claude.md한번 챙겨주세용~ 거긴 hotfix도 있는거 같아요 크크
There was a problem hiding this comment.
2 participants
요약
UserConfig타이핑 제거, conventional preset만 사용하도록 설정 단순화@commitlint패키지 v19 → v20 업그레이드@commitlint/cz-commitlint의 peer dependency인inquirer@9추가@commitlint/typesdevDependency 제거Closes #233