Release#256
Merged
froggy1014 merged 19 commits intomainfrom Apr 27, 2026
Merged
Conversation
* fix(build): preserve css imports in sideEffects * fix(build): preserve css side effects in template * chore(changeset): add css sideEffects fix note * chore(changeset): fix package list and description
* refactor(flex): align story options with constants - replace hardcoded story options with Flex constants - keep Storybook controls aligned with the current contract values - reduce the risk of drift between implementation and story definitions * test(flex): strengthen contract coverage - align tests with the current Flex contract in side - use constants as the source of truth for direction, align, justify, and wrap cases - add coverage for normal values, asChild behavior, style overrides, ref forwarding, and common consumer usage patterns - verify the Flex test suite passes at the package level * test(flex): translate test descriptions to english --------- Co-authored-by: KYBee <kybee@KYBeeui-Macmini.local>
* feat: primitive token * fix: ci error * docs: update spacing primitive token * docs: update radius primitive token
* fix(tooltip): add aria-label for screen readers * refactor(tooltip): migrate styles to vanilla-extract recipe * test(tooltip): improve accessibility test coverage * refactor(tooltip): use enum instead of string literal * fix(tooltip): resolve type import error * test(tooltip): translate test descriptions to English * chore(tooltip): remove export and add changeset
froggy1014
requested review from
3o14,
G-hoon,
KYBee,
Yeom-JinHo,
haedawn,
minjeeki,
minji0214 and
osohyun0224
as code owners
🦋 Changeset detectedLatest commit: c1166b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (7)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
3o14
added a commit
that referenced
this pull request
Apr 28, 2026
…as strategy (#258) * feat(tokens): update primitive token JSON with extended scale Add missing color shades (gray.950, status colors), expanded radius, spacing, and typography scales to align with semantic token requirements. Confidence: high Scope-risk: narrow * feat(tokens): add semantic token JSON draft in DTCG format Introduce dark-mode semantic tokens for color, spacing, radius, and typography. All values reference primitive aliases only — no raw hex or px values. Each token includes two usage-scenario descriptions. Light-mode tokens are deferred (tokens/semantic/light/ has .gitkeep only). Confidence: high Scope-risk: narrow * feat(tokens): redesign CSS contract to match semantic token structure Rewrite vars contract to reflect semantic layers (color.background.*, color.foreground.*, color.accent.*, spacing.component.*, spacing.layout.*, radius.component.*, radius.layout.*). Extract darkBaseColor shared object and define four brand theme variants (default, 1st–4th). Constraint: dark mode is the default; light mode is deferred Rejected: per-theme contract files | increases maintenance surface Confidence: high Scope-risk: broad * feat(button): migrate styles to new semantic vars paths Update all token references to match the redesigned CSS contract: color.primary → color.accent.default, spacing.sm/lg → spacing.component.*, radius.md → radius.component.md, focus ring wired to color.border.focus. Confidence: high Scope-risk: narrow * chore(tokens): mark unused TS primitive exports as deprecated Add @deprecated JSDoc to opacity, zIndex, borderWidth/borderStyle, shadows, spacing, breakpoints, grid, and responsiveStyle. These TS source files will be removed alongside all other TS primitives once the JSON token pipeline is complete and components have migrated to vars.*. Directive: do not add new consumers of these exports Confidence: high Scope-risk: narrow * chore: changeset * feat(tokens): add brand primitive and update accent semantic alias - Add color.brand.{default,hover,subtle} to primitive/color.json with current cohort values (#ffb24d, #d9963f, #3b2005) - Update semantic accent.* to reference {color.brand.*} instead of blue to reflect actual brand color brand primitive acts as the single update point per cohort; semantic tokens and components require no changes on rebranding. * feat(tokens): add brandColor and update defaultTheme accent to orange - Export brandColor const from colors.ts (mirrors primitive brand.*) - Import brandColor in themes.css.ts and apply to defaultTheme accent replacing hardcoded blue values Note: colors.ts and themes.css.ts are deprecated and will be removed once the Style Dictionary pipeline is in place. * fix(theme): correct assignInlineVars contract mapping in ThemeProvider assignInlineVars(vars.color, theme) was passing ThemeColor { primary, secondary, background, text, gradient } to a contract that expects { accent, foreground, border, status, ... }, causing a TypeScript error and no-op CSS variable assignment. Fix by scoping to vars.color.accent and mapping ThemeColor fields: - primary → accent.default - secondary → accent.hover - background → accent.subtle * docs(tokens): add semantic token proposal with rebrand strategy - Document semantic token structure (color, spacing, radius, typography) - Add rebranding flow section explaining brand primitive alias pattern: update color.brand.* in primitive/color.json only on cohort change - Note W3C Design Token format compatibility with Token Studio v2 and Style Dictionary v4 for upcoming Figma pipeline integration * fix(tokens): remove duplicate named exports from themes.css.ts theme1st–theme4th were exported from both colors.ts (ThemeColor objects) and themes.css.ts (createGlobalTheme return values), causing TS2308 ambiguous re-export errors in src/index.ts. createGlobalTheme calls are CSS side effects; their return values are not consumed by any external code, so export keywords are removed. * Release (#256) Co-authored-by: KYBee <kybee@KYBeeui-Macmini.local> Co-authored-by: Jinho Yeom <81306489+Yeom-JinHo@users.noreply.github.com> Co-authored-by: 이원주 <101818687+3o14@users.noreply.github.com> Co-authored-by: YOUNGBEEN, KIM <62539910+KYBee@users.noreply.github.com> Co-authored-by: 오소현 <53892427+osohyun0224@users.noreply.github.com> Co-authored-by: Minji Jeon <105787441+minji0214@users.noreply.github.com> * chore: update changeset BC * docs: update semantic-proposal docs * docs: modify semantic proposal muted token * fix: modify spacing, radius themes * chore: update deprecated annotation --------- Co-authored-by: Evan <clcl6084@gmail.com> Co-authored-by: KYBee <kybee@KYBeeui-Macmini.local> Co-authored-by: Jinho Yeom <81306489+Yeom-JinHo@users.noreply.github.com> Co-authored-by: YOUNGBEEN, KIM <62539910+KYBee@users.noreply.github.com> Co-authored-by: 오소현 <53892427+osohyun0224@users.noreply.github.com> Co-authored-by: Minji Jeon <105787441+minji0214@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Features
tokens/primitive/에 color, radius, spacing, typography JSON 기반 토큰 정의추가 (feat(tokens): define primitive token foundations #248)
🐛 Fixes
./styles.css를 tree-shake하지 않도록sideEffects보존 (fix(build): preserve css imports in sideEffects #228)--if-present플래그 추가 (fix(ci): add --if-present flag to pnpm filter commands #238)🔧 Chores / Infra
.storybook설정 제거 → 루트 Storybook으로 통합 (chore: remove per-package .storybook configs #250)plugin-figma-codegen패키지 제거 (chore: remove plugin-figma-codegen package #251)build,typecheck,test:coverage)📚 Docs
🧪 Tests
@sipe-team/flex계약 커버리지 강화