Skip to content

Fix headings and verse 0 being used in quality estimation #3991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nateowami merged 1 commit into from
Jul 13, 2026
Merged

Fix headings and verse 0 being used in quality estimation #3991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/SIL.XForge.Scripture/Services/PreTranslationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ PretranslationConfidence pretranslationConfidence in await translationEnginesCli
continue;
}

// If there is a forward slash, in the reference, the first half is the verse reference
// If there is a forward slash in the reference, do not use this confidence score, as it is a heading
if (reference.Contains('/', StringComparison.OrdinalIgnoreCase))
{
reference = reference.Split('/', StringSplitOptions.RemoveEmptyEntries).FirstOrDefault();
continue;
}

// Ensure we have a valid verse reference and it is for this chapter
Expand All @@ -73,12 +73,14 @@ PretranslationConfidence pretranslationConfidence in await translationEnginesCli
continue;
}

// Add the confidence value. However, if the confidence value already exists, see if this pre-translation
// is for the verse content, and if so, set the confidence value.
if (!confidences.TryAdd(verseRef, pretranslationConfidence.Confidence) && !references.First().Contains('/'))
// Skip verse 0. This is usually the headings and introduction above chapter 1
if (verseRef.VerseNum == 0)
{
confidences[verseRef] = pretranslationConfidence.Confidence;
continue;
}

// Add the confidence value, if there is no confidence value already specified
confidences.TryAdd(verseRef, pretranslationConfidence.Confidence);
}

return confidences.Select(c => new VerseConfidence(c.Key.BookNum, c.Key.ChapterNum, c.Key.Verse, c.Value));
Expand Down
33 changes: 16 additions & 17 deletions test/SIL.XForge.Scripture.Tests/Services/PreTranslationServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,10 +370,9 @@ public async Task GetVerseConfidencesAsync_Success()
[
.. await env.Service.GetVerseConfidencesAsync(Project01, CancellationToken.None),
];
Assert.That(actual, Has.Count.EqualTo(3));
Assert.That(actual, Has.Count.EqualTo(2));
Assert.That(actual[0], Is.EqualTo(new VerseConfidence(40, 1, "1", 0.2)).UsingPropertiesComparer());
Assert.That(actual[1], Is.EqualTo(new VerseConfidence(40, 1, "2", 0.4)).UsingPropertiesComparer());
Assert.That(actual[2], Is.EqualTo(new VerseConfidence(40, 1, "3", 0.7)).UsingPropertiesComparer());
Assert.That(actual[1], Is.EqualTo(new VerseConfidence(40, 1, "3", 0.6)).UsingPropertiesComparer());
}

private class TestEnvironmentOptions
Expand Down Expand Up @@ -418,7 +417,7 @@ public TestEnvironment(TestEnvironmentOptions? options = null)
Task.FromResult<IList<PretranslationConfidence>>([
new PretranslationConfidence
{
// A pre-translation confidence value with no references
// A pre-translation confidence value with no references (ignored)
SourceRefs = [],
TargetRefs = [],
Confidence = 0.1,
Expand All @@ -432,37 +431,37 @@ public TestEnvironment(TestEnvironmentOptions? options = null)
},
new PretranslationConfidence
{
// A pre-translation confidence value with an invalid references
// A pre-translation confidence value with an invalid references (ignored)
SourceRefs = ["invalid_reference"],
TargetRefs = ["invalid_reference"],
Confidence = 0.3,
},
new PretranslationConfidence
{
// A pre-translation confidence value from a segment
SourceRefs = ["MAT 1:2/1:p"],
TargetRefs = ["MAT 1:2/1:p"],
// A pre-translation confidence value from verse that only has a segment (ignored)
SourceRefs = ["MAT 1:2/1:s"],
TargetRefs = ["MAT 1:2/1:s"],
Confidence = 0.4,
},
new PretranslationConfidence
{
// A pre-translation confidence value from a segment that will be overridden by the verse
SourceRefs = ["MAT 1:3/2:p"],
TargetRefs = ["MAT 1:3/2:p"],
// A pre-translation confidence value from a segment (ignored)
SourceRefs = ["MAT 1:3/2:s"],
TargetRefs = ["MAT 1:3/2:s"],
Confidence = 0.5,
},
new PretranslationConfidence
{
// A pre-translation confidence value from another segment that will be overridden by the verse
SourceRefs = ["MAT 1:3/3:p"],
TargetRefs = ["MAT 1:3/3:p"],
// A pre-translation confidence value for a verse
SourceRefs = ["MAT 1:3"],
TargetRefs = ["MAT 1:3"],
Confidence = 0.6,
},
new PretranslationConfidence
{
// A pre-translation confidence value for a verse
SourceRefs = ["MAT 1:3"],
TargetRefs = ["MAT 1:3"],
// A pre-translation confidence value for verse zero (ignored)
SourceRefs = ["MAT 1:0"],
TargetRefs = ["MAT 1:0"],
Confidence = 0.7,
},
])
Expand Down
Loading