Fix headings and verse 0 being used in quality estimation#3991
Merged
Conversation
pmachapman
added
critical path
pmachapman
temporarily deployed
to
screenshot_diff
July 9, 2026 02:32 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3991 +/- ##
==========================================
- Coverage 81.03% 81.03% -0.01%
==========================================
Files 645 645
Lines 41523 41522 -1
Branches 6739 6763 +24
==========================================
- Hits 33650 33649 -1
+ Misses 6774 6761 -13
- Partials 1099 1112 +13 ☔ View full report in Codecov by Harness. |
pmachapman
force-pushed
the
fix/quality_estimation
branch
from
July 13, 2026 19:22
bd0d8b8 to
af32f76
Compare
pmachapman
temporarily deployed
to
screenshot_diff
July 13, 2026 19:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
pmachapman
force-pushed
the
fix/quality_estimation
branch
from
July 13, 2026 19:30
af32f76 to
afa0537
Compare
pmachapman
temporarily deployed
to
screenshot_diff
July 13, 2026 19:36 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
pmachapman
force-pushed
the
fix/quality_estimation
branch
from
July 13, 2026 19:56
afa0537 to
7d7b4e9
Compare
pmachapman
force-pushed
the
fix/quality_estimation
branch
from
July 13, 2026 19:59
7d7b4e9 to
7cce811
Compare
Nateowami
approved these changes
Jul 13, 2026
Nateowami
left a comment
Nateowami
left a comment
Collaborator
There was a problem hiding this comment.
@Nateowami reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
pmachapman
temporarily deployed
to
screenshot_diff
July 13, 2026 20:06 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in quality estimation calculation where verses that only contained headings, and verse 0 was being included in the quality estimation calculation.
I have marked as testing not required, as the unit test covers the scope of the change, and it really can only be tested on production by an EITL.
I have verified the output of this as corresponding to the output from silnlp for the same confidence values.
This change is