scalafmt: use sbt plugin, add to tests workflow#1120
Open
kitbellew wants to merge 1 commit intoscalacenter:mainfrom
Open
scalafmt: use sbt plugin, add to tests workflow#1120kitbellew wants to merge 1 commit intoscalacenter:mainfrom
kitbellew wants to merge 1 commit intoscalacenter:mainfrom
Conversation
kitbellew
force-pushed
the
use-sbt-scalafmt
branch
from
145e1b6 to
f834dcb
Compare
Contributor
Author
|
fyi: @rochala |
Contributor
Author
|
this should ideally be fixed. |
The formatting test will be failing until format is fixed, but for now so are some other tests. Remove `bin/scalafmt` which no longer works.
kitbellew
force-pushed
the
use-sbt-scalafmt
branch
from
f834dcb to
7b7413c
Compare
Contributor
Author
Contributor
|
Might be better to wait until the refactoring is done though? I will talk with @rochala about it. |
Contributor
Author
|
we can postpone adding the formatting check but the fact that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatting test will be failing until format is fixed, but for now so are some other tests.
Remove
bin/scalafmtwhich no longer works.