Decouple rosout publisher init from node init.#351
Merged
JanStaschulat merged 1 commit intoApr 28, 2023
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 69.20% 68.96% -0.25%
==========================================
Files 16 16
Lines 2715 2723 +8
Branches 765 770 +5
==========================================
- Hits 1879 1878 -1
- Misses 450 456 +6
- Partials 386 389 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fujitatomoya
commented
Apr 28, 2023
JanStaschulat
approved these changes
Apr 28, 2023
Author
|
@JanStaschulat thanks for the review, but
we should wait until this dependent fix is merged. do you want me to revert this? |
fujitatomoya
pushed a commit
to fujitatomoya/rclc
that referenced
this pull request
Apr 29, 2023
This reverts commit b507003. Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
JanStaschulat
pushed a commit
that referenced
this pull request
May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on ros2/rcl#1065
address ros2/rclcpp#2147