Skip to content

chore: main: update protobufjs to fix CVE-2026-41242#4745

Merged
openshift-merge-bot[bot] merged 2 commits intoredhat-developer:mainfrom
kim-tsao:main_protobufjs
May 6, 2026
Merged

chore: main: update protobufjs to fix CVE-2026-41242#4745
openshift-merge-bot[bot] merged 2 commits intoredhat-developer:mainfrom
kim-tsao:main_protobufjs

Conversation

@kim-tsao
Copy link
Copy Markdown
Member

@kim-tsao kim-tsao commented May 1, 2026

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?
  • Fix CVE-2026-41242 by adding bumping protobufjs to v7.5.6 and pinning its transitive dependency @protobufjs/inquire to v1.1.0 to avoid the following error:
app:  Error: Failed to compile '../../node_modules/protobufjs/node_modules/@protobufjs/inquire/index.js':
app:    Critical dependency: the request of a dependency is an expression

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci Bot requested review from rostalan and schultzp2020 May 1, 2026 19:22
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.04%. Comparing base (5a6cf35) to head (aa328e6).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4745       +/-   ##
===========================================
+ Coverage   40.98%   69.04%   +28.06%     
===========================================
  Files         119      118        -1     
  Lines        2223     4898     +2675     
  Branches      561      532       -29     
===========================================
+ Hits          911     3382     +2471     
- Misses       1306     1511      +205     
+ Partials        6        5        -1     
Flag Coverage Δ
install-dynamic-plugins 92.44% <ø> (?)
rhdh 40.30% <ø> (-0.68%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6cf35...aa328e6. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

The container image build workflow finished with status: failure.

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

The container image build workflow finished with status: failure.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

The container image build workflow finished with status: failure.

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao kim-tsao force-pushed the main_protobufjs branch from acb605e to 0b2fbbd Compare May 4, 2026 23:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

The container image build workflow finished with status: cancelled.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

The container image build workflow finished with status: failure.

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Image was built and published successfully. It is available at:

@kim-tsao
Copy link
Copy Markdown
Member Author

kim-tsao commented May 5, 2026

/test e2e-ocp-helm

1 similar comment
@alizard0
Copy link
Copy Markdown
Member

alizard0 commented May 5, 2026

/test e2e-ocp-helm

@kim-tsao
Copy link
Copy Markdown
Member Author

kim-tsao commented May 5, 2026

/retest

@kim-tsao kim-tsao changed the title chore: main: update protobufjs to 7.5.5 to fix CVE-2026-41242 chore: main: update protobufjs to fix CVE-2026-41242 May 5, 2026
Copy link
Copy Markdown
Member

@alizard0 alizard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kim-tsao
Copy link
Copy Markdown
Member Author

kim-tsao commented May 6, 2026

/retest

@openshift-merge-bot openshift-merge-bot Bot merged commit 6d1ace8 into redhat-developer:main May 6, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants