Skip to content

chore: add a resolution to @backstage/backend-plugin-api#4756

Closed
kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
kim-tsao:lockdown_backend-plugin-api
Closed

chore: add a resolution to @backstage/backend-plugin-api#4756
kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
kim-tsao:lockdown_backend-plugin-api

Conversation

@kim-tsao
Copy link
Copy Markdown
Member

@kim-tsao kim-tsao commented May 4, 2026

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?
  • yarn export-dynamic is failing in this PR for techdocs backend due to incompatibility of versions in the @backstage/backend-plugin-api. In the embedded module, it's v1.8.0 while the dynamic-plugins/yarn.lock is at v1.9.0.

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci openshift-ci Bot requested review from dom-aug and invincibleJai May 4, 2026 17:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Image was built and published successfully. It is available at:

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.04%. Comparing base (5a6cf35) to head (36332c3).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4756       +/-   ##
===========================================
+ Coverage   40.98%   69.04%   +28.06%     
===========================================
  Files         119      118        -1     
  Lines        2223     4898     +2675     
  Branches      561      556        -5     
===========================================
+ Hits          911     3382     +2471     
- Misses       1306     1510      +204     
  Partials        6        6               
Flag Coverage Δ
install-dynamic-plugins 92.44% <ø> (?)
rhdh 40.30% <ø> (-0.68%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6cf35...36332c3. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

The container image build workflow finished with status: failure.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 4, 2026

@kim-tsao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm a033e99 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Image was built and published successfully. It is available at:

@kim-tsao kim-tsao closed this May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant