fix: MacOS support#14544
Draft
brianferri wants to merge 1 commit intorealsenseai:developmentfrom
Draft
Conversation
|
Can one of the admins verify this patch? |
This is the first of probably many other commits that will attempt to bring realsense application back to being at least runnable on Mac. --- Specifically, in this commit, referencing this issue realsenseai#12727, the main drive was to fix (or at least lessen) the segmentation faults you get once you connect your realsense device to a USB port on an M-Series Mac, running any modern MacOS version. The `return_error` flag logic was completely removed, replaced with early returns to prevent potential dereferences of uninitialized or failed handles. I also updated the code to use modern Apple IOKit constants, [mentioned here](libusb/hidapi#377).
brianferri
force-pushed
the
development
branch
from
33ddec2 to
c5c44f8
Compare
Contributor
|
@brianferri |
Contributor
Author
This is a draft PR, I haven't touched any specific sensor logic yet. You can check the commit history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MacOS Compatibility Restoration (M-Series/Modern macOS)
Goal
The primary objective of this PR is to address the stability issues introduced by modern macOS versions and Apple Silicon (M1/M2/M3) architecture. Currently, the application frequently encounters segmentation faults during device discovery and initialization.