Skip to content

Test Files for taxonomic classification#344

Closed
heracle wants to merge 6 commits into
masterfrom
mtg_taxclass_2
Closed

Test Files for taxonomic classification#344
heracle wants to merge 6 commits into
masterfrom
mtg_taxclass_2

Conversation

@heracle

@heracle heracle commented Jul 28, 2021

Copy link
Copy Markdown
Collaborator

Add the test files that will be further used inside unit and integration taxonomic tests

heracle added 5 commits July 28, 2021 16:08
Signed-off-by: Radu Muntean <radu.muntean.2@gmail.com>
Signed-off-by: Radu Muntean <radu.muntean.2@gmail.com>
Signed-off-by: Radu Muntean <radu.muntean.2@gmail.com>
@heracle heracle requested review from hmusta and karasikov July 28, 2021 18:07
Base automatically changed from mtg_taxclass_1 to master July 28, 2021 19:58

@karasikov karasikov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the code too. Otherwise this data is useless

@heracle

heracle commented Jul 30, 2021

Copy link
Copy Markdown
Collaborator Author

Thanks for reviewing my PRs! I am trying to split the code into small pieces and to send them in an order that would make sense. I will add these files in another PR with all the integration tests

@karasikov

Copy link
Copy Markdown
Member

I don't see how these files are used. Please merge to the next PR.

@heracle

heracle commented Aug 3, 2021

Copy link
Copy Markdown
Collaborator Author

I will merge them to #348 , the PR with the CLI and the integration tests. Thanks!

Signed-off-by: Radu Muntean <radu.muntean.2@gmail.com>
@heracle

heracle commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator Author

closing this after moving the files to #348

@heracle heracle closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants