Skip to content

Add support of bisection decomposition in the test suite #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbrucy merged 3 commits into from
Dec 19, 2025
+24 −11
Merged

Add support of bisection decomposition in the test suite #220

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d09ec9
Add support of bisection decomposition in the test suite
matthiasglz Dec 3, 2025
9275dcf
Correct bug introduced in previous commit, in the Hilbert ordering case
matthiasglz Dec 5, 2025
56f95ec
Merge branch 'dev' into bisection
nbrucy Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions tests/visu/visu_ramses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,19 +225,32 @@ def load_snapshot(nout, read_hydro=True, read_grav=False, read_rt=False):
offset = 4*ninteg + 8*(nlines+nfloat) + nstrin + nquadr*16 + 4
ngridlevel[info["ncpu"]:info["ncpu"]+nboundary,:] = np.asarray(struct.unpack("%ii"%(nboundary*info["levelmax"]), amrContent[offset:offset+4*nboundary*info["levelmax"]])).reshape(info["levelmax"],nboundary).T

# Determine bound key precision
ninteg = 14+(3*info["ncpu"]*info["levelmax"])+(10*info["levelmax"])+(3*nboundary*info["levelmax"])+5
nfloat = 18+(2*noutput)+(2*info["levelmax"])
nlines = 21+2+3*min(1,nboundary)+1+1
nstrin = 128
nquadr = 0
offset = 4*ninteg + 8*(nlines+nfloat) + nstrin + nquadr*16
key_size = struct.unpack("i", amrContent[offset:offset+4])[0]
# Depending on the ordering type, we have two different cases
if(info["ordering type"] == "bisection"):
nbinodes = 2**(math.ceil(math.log(float(info["ncpu"]))/math.log(2.0))+1)-1
ninteg_ordering = 3*nbinodes
nfloat_ordering = nbinodes+2*info["ncpu"]*info["ndim"]
nlines_ordering = 5
key_size = 0
else:
nbinodes = 0
ninteg_ordering = 0
nfloat_ordering = 0
nlines_ordering = 1

# Determine bound key precision
Copy link
Copy Markdown
Collaborator

@nbrucy nbrucy Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the indentation correct?

Copy link
Copy Markdown
Contributor Author

@matthiasglz matthiasglz Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Copy Markdown
Contributor Author

@matthiasglz matthiasglz Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But actually I introduced a bug in the Hilbert case, sorry.
I will commit the corrected file, and then add the corresponding sink/spawning test with ordering='bisection' in the test suite

ninteg = 14+(3*info["ncpu"]*info["levelmax"])+(10*info["levelmax"])+(3*nboundary*info["levelmax"])+5
nfloat = 18+(2*noutput)+(2*info["levelmax"])
nlines = 21+2+3*min(1,nboundary)+1+1
nstrin = 128
nquadr = 0
offset = 4*ninteg + 8*(nlines+nfloat) + nstrin + nquadr*16
key_size = struct.unpack("i", amrContent[offset:offset+4])[0]

# Offset for AMR
ninteg1 = 14+(3*info["ncpu"]*info["levelmax"])+(10*info["levelmax"])+(3*nboundary*info["levelmax"])+5+3*ncoarse
nfloat1 = 18+(2*noutput)+(2*info["levelmax"])
nlines1 = 21+2+3*min(1,nboundary)+1+1+1+3
ninteg1 = 14+(3*info["ncpu"]*info["levelmax"])+(10*info["levelmax"])+(3*nboundary*info["levelmax"])+5+ninteg_ordering+3*ncoarse
nfloat1 = 18+(2*noutput)+(2*info["levelmax"])+nfloat_ordering
nlines1 = 21+2+3*min(1,nboundary)+1+1+nlines_ordering+3
nstrin1 = 128 + key_size

# Offset for HYDRO
Expand Down