Add support of bisection decomposition in the test suite#220
Merged
nbrucy merged 3 commits intoramses-organisation:devfrom Dec 19, 2025
Merged
Add support of bisection decomposition in the test suite#220nbrucy merged 3 commits intoramses-organisation:devfrom
nbrucy merged 3 commits intoramses-organisation:devfrom
Conversation
nbrucy
reviewed
Dec 4, 2025
| nfloat_ordering = 0 | ||
| nlines_ordering = 1 | ||
|
|
||
| # Determine bound key precision |
Collaborator
There was a problem hiding this comment.
Is the indentation correct?
Contributor
Author
There was a problem hiding this comment.
But actually I introduced a bug in the Hilbert case, sorry.
I will commit the corrected file, and then add the corresponding sink/spawning test with ordering='bisection' in the test suite
nbrucy
added
run tests
tinecolman
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #72
Thanks to @cphyc for the help and for adapting Yt to add support on this bisection decomposition (see yt-project/yt#5340)
PR Checklist