Skip to content

misc: polymarket rules component extraction#7369

Merged
i1skn merged 1 commit intodevelopfrom
04-20-misc_polymarket_rules_component_extraction
Apr 21, 2026
Merged

misc: polymarket rules component extraction#7369
i1skn merged 1 commit intodevelopfrom
04-20-misc_polymarket_rules_component_extraction

Conversation

@i1skn
Copy link
Copy Markdown
Contributor

@i1skn i1skn commented Apr 20, 2026

Description

Polymarket currently shows the rules CTA even when the description is too short for that affordance to be useful. This extracts the description card into a shared
ExpandableDescriptionCard so the CTA only appears once the content reaches the truncation threshold, and so the same component can be reused in the perps market About flow in
#7354.

What to test

  • Open a Polymarket event with a short description and confirm the CTA does not show.
  • Open a Polymarket event with a longer description and confirm the CTA shows and still opens the rules sheet.

Screenshots

Before

Simulator Screenshot - iPhone 17 Pro - 2026-04-20 at 18.12.05.png

After

Simulator Screenshot - iPhone 17 Pro - 2026-04-20 at 17.56.53.png

Copy link
Copy Markdown
Contributor Author

i1skn commented Apr 20, 2026

@i1skn i1skn force-pushed the 04-15-misc_update_nktkas_hyperliquid_lib branch from 50332a7 to f2e0f4d Compare April 20, 2026 17:08
@i1skn i1skn force-pushed the 04-20-misc_polymarket_rules_component_extraction branch 2 times, most recently from e25547a to 1df4db3 Compare April 20, 2026 17:17
@i1skn i1skn requested a review from maxbbb April 20, 2026 17:19
@i1skn i1skn marked this pull request as ready for review April 20, 2026 17:19
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for b5b7419

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

🧪 Flashlight Performance Report (AWS Device Farm)

🔀 Commit: e0b5128

📎 View Artifacts

Metric Current Δ vs Baseline
Time to Interactive (TTI) 5547 ms ⚪ -30.7 ms (-0.6%)
Average FPS 56.89 ⚪ +0.1 (+0.2%)
Average RAM 393.7 MB 🟢 -4.9 MB (-1.2%)

Copy link
Copy Markdown
Contributor Author

i1skn commented Apr 21, 2026

Merge activity

  • Apr 21, 12:46 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 21, 12:48 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 21, 1:06 PM UTC: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'E2E Tests (Shard 1)').

@i1skn i1skn changed the base branch from 04-15-misc_update_nktkas_hyperliquid_lib to graphite-base/7369 April 21, 2026 12:46
@i1skn i1skn changed the base branch from graphite-base/7369 to develop April 21, 2026 12:47
@i1skn i1skn force-pushed the 04-20-misc_polymarket_rules_component_extraction branch from 1df4db3 to df4664f Compare April 21, 2026 12:47
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for 5261f42

@i1skn i1skn force-pushed the 04-20-misc_polymarket_rules_component_extraction branch from df4664f to 598ddfc Compare April 21, 2026 21:33
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for e0b5128

@i1skn i1skn merged commit fa2e7f4 into develop Apr 21, 2026
21 checks passed
@i1skn i1skn deleted the 04-20-misc_polymarket_rules_component_extraction branch April 21, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants