Skip to content

feat: add name + description + about section to Perps Markets#7354

Merged
i1skn merged 1 commit intodevelopfrom
04-15-feat_add_name_description_to_perps_markets
Apr 21, 2026
Merged

feat: add name + description + about section to Perps Markets#7354
i1skn merged 1 commit intodevelopfrom
04-15-feat_add_name_description_to_perps_markets

Conversation

@i1skn
Copy link
Copy Markdown
Contributor

@i1skn i1skn commented Apr 15, 2026

Fixes https://linear.app/rainbow/issue/APP-3529/add-name-description-to-perps-markets

What changed (plus any additional context for devs)

This PR introduces names and descriptions for each Hyperliquid market, along with a basic “About” section. We load name and description directly from HL API, as our backend does not expose it.

Because the market name is fetched via a separate network request, we display a loader until that data is available.

Descriptions are shown only for markets where they exist. However, the rest of the “About” section remains visible for all markets, regardless of whether a description is present.

Screen recordings / screenshots

Simulator Screen Recording - iPhone 17 Pro - 2026-04-14 at 22.29.00.mov (uploaded via Graphite)

What to test

  • Market with where name and symbol are equal shows it only once (BRENTOIL)
  • Market with different name and symbol shows both (CL)
  • Loader is not visible for a long time
  • About section has 3 info rows for all the markets
  • About section has description for some markets (commodities mainly)
  • Description is truncated after 3rd row
  • User can click on description, which open a modal with full text of description

Copy link
Copy Markdown
Contributor Author

i1skn commented Apr 15, 2026

@i1skn i1skn force-pushed the 04-15-feat_add_name_description_to_perps_markets branch from 1f5ee0d to 9f17916 Compare April 15, 2026 16:01
@linear
Copy link
Copy Markdown

linear Bot commented Apr 15, 2026

@i1skn i1skn force-pushed the 04-15-feat_add_name_description_to_perps_markets branch from 9f17916 to 8861ead Compare April 15, 2026 17:15
@i1skn i1skn force-pushed the 04-15-misc_update_nktkas_hyperliquid_lib branch 2 times, most recently from 192a700 to 50332a7 Compare April 16, 2026 15:47
@i1skn i1skn force-pushed the 04-15-feat_add_name_description_to_perps_markets branch from 8861ead to 1a153b5 Compare April 16, 2026 15:47
@i1skn i1skn requested review from maxbbb and olerass April 16, 2026 15:49
@i1skn i1skn marked this pull request as ready for review April 16, 2026 15:49
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for 4e86a39

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

🧪 Flashlight Performance Report (AWS Device Farm)

🔀 Commit: fe4fe0f

📎 View Artifacts

Metric Current Δ vs Baseline
Time to Interactive (TTI) 5608 ms ⚪ +19.4 ms (+0.3%)
Average FPS 56.65 ⚪ +0.0 (+0.0%)
Average RAM 396.2 MB ⚪ -3.7 MB (-0.9%)

@i1skn i1skn changed the title feat: add name + description to Perps Markets feat: add name + description + about section to Perps Markets Apr 17, 2026
Copy link
Copy Markdown
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's, QA Passed 👍🏽

Comment thread src/features/perps/stores/perpAnnotationsStore.ts Outdated
Comment thread src/features/perps/screens/perp-detail-screen/AboutSection.tsx Outdated
Comment thread src/features/perps/screens/perps-about-sheet/PerpsAboutSheet.tsx Outdated
Comment thread src/features/perps/screens/perp-detail-screen/PerpDetailScreen.tsx Outdated
Comment thread src/features/perps/components/PerpsNameRow.tsx Outdated
Comment thread src/features/perps/screens/perp-detail-screen/PerpDetailScreen.tsx Outdated
@i1skn i1skn changed the base branch from 04-15-misc_update_nktkas_hyperliquid_lib to graphite-base/7354 April 20, 2026 17:00
@i1skn i1skn force-pushed the 04-15-feat_add_name_description_to_perps_markets branch from 1a153b5 to 5c35247 Compare April 20, 2026 17:00
@i1skn i1skn force-pushed the graphite-base/7354 branch from e74466d to e25547a Compare April 20, 2026 17:08
@i1skn i1skn force-pushed the 04-15-feat_add_name_description_to_perps_markets branch from 5c35247 to 2830225 Compare April 20, 2026 17:08
@i1skn i1skn changed the base branch from graphite-base/7354 to 04-20-misc_polymarket_rules_component_extraction April 20, 2026 17:08
@i1skn i1skn force-pushed the 04-15-feat_add_name_description_to_perps_markets branch from 2830225 to 07f9100 Compare April 20, 2026 17:17
@i1skn i1skn force-pushed the 04-20-misc_polymarket_rules_component_extraction branch from e25547a to 1df4db3 Compare April 20, 2026 17:17
@i1skn i1skn requested a review from maxbbb April 20, 2026 17:18
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for 7103ff7

@i1skn i1skn changed the base branch from 04-20-misc_polymarket_rules_component_extraction to graphite-base/7354 April 21, 2026 12:47
@i1skn i1skn force-pushed the 04-15-feat_add_name_description_to_perps_markets branch from 07f9100 to 887844d Compare April 21, 2026 21:33
@i1skn i1skn force-pushed the graphite-base/7354 branch from 1df4db3 to 598ddfc Compare April 21, 2026 21:33
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for 51ab2a2

i1skn added a commit that referenced this pull request Apr 21, 2026
## Description

Polymarket currently shows the rules CTA even when the description is too short for that affordance to be useful. This extracts the description card into a shared
`ExpandableDescriptionCard` so the CTA only appears once the content reaches the truncation threshold, and so the same component can be reused in the perps market About flow in
#7354.

## What to test

- Open a Polymarket event with a short description and confirm the CTA does not show.
- Open a Polymarket event with a longer description and confirm the CTA shows and still opens the rules sheet.

## Screenshots

Before

![Simulator Screenshot - iPhone 17 Pro - 2026-04-20 at 18.12.05.png](https://app.graphite.com/user-attachments/assets/14c0786f-84aa-4578-ba80-842231386e86.png)

After

![Simulator Screenshot - iPhone 17 Pro - 2026-04-20 at 17.56.53.png](https://app.graphite.com/user-attachments/assets/7454b0f3-1ef5-43ae-aefb-a7aa09ad840b.png)
@i1skn i1skn force-pushed the 04-15-feat_add_name_description_to_perps_markets branch from 887844d to 1f0f4b4 Compare April 21, 2026 22:05
@i1skn i1skn force-pushed the graphite-base/7354 branch from 598ddfc to fa2e7f4 Compare April 21, 2026 22:05
@graphite-app graphite-app Bot changed the base branch from graphite-base/7354 to develop April 21, 2026 22:05
@i1skn i1skn force-pushed the 04-15-feat_add_name_description_to_perps_markets branch from 1f0f4b4 to 5580506 Compare April 21, 2026 22:05
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for fe4fe0f

@i1skn i1skn merged commit 2f9fe37 into develop Apr 21, 2026
21 checks passed
@i1skn i1skn deleted the 04-15-feat_add_name_description_to_perps_markets branch April 21, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants