Skip to content

fix(android): add gap between token list sheet and keyboard (APP-3442)#7107

Draft
i1skn wants to merge 1 commit intodevelopfrom
02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_
Draft

fix(android): add gap between token list sheet and keyboard (APP-3442)#7107
i1skn wants to merge 1 commit intodevelopfrom
02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_

Conversation

@i1skn
Copy link
Copy Markdown
Contributor

@i1skn i1skn commented Feb 6, 2026 •
edited
Loading

Fixes APP-3442

What changed (plus any additional context for devs)

  • Added an Android-only bottom gap between the token list sheet and keyboard when the token search input is focused.
  • Updated TOKEN_SEARCH_FOCUSED_INPUT_HEIGHT to subtract an additional 12 px on Android via IS_ANDROID.
  • iOS behavior is unchanged.

Screen recordings / screenshots

Before After
Screenshot_1770410559.png Screenshot_1770410214.png

What to test

  • On Android, open token search and focus the input; verify there is a visible gap between the sheet content and keyboard.
  • Confirm the focused search layout still fits the screen correctly without clipping.
  • On iOS, verify token search layout remains unchanged.

@linear
Copy link
Copy Markdown

linear Bot commented Feb 6, 2026

APP-3442 Add gap between token list sheet and keyboard [Android]

This was referenced Feb 6, 2026
Merged
Merged
Merged
@i1skn Graphite App
Copy link
Copy Markdown
Contributor Author

i1skn commented Feb 6, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@i1skn i1skn mentioned this pull request Feb 6, 2026
Merged
@i1skn i1skn changed the base branch from 02-05-chrore_extract_token_search_input_and_button to graphite-base/7107 February 6, 2026 20:55
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch from 2e69569 to 33335af Compare February 6, 2026 20:55
@i1skn i1skn changed the base branch from graphite-base/7107 to 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector February 6, 2026 20:55
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch from 33335af to 1fcbbca Compare February 9, 2026 12:38
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch 2 times, most recently from 87180c9 to bd555dd Compare February 9, 2026 14:34
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch 2 times, most recently from 97e0dd4 to 9b2b6a4 Compare February 9, 2026 16:34
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from e423007 to 83e6108 Compare February 9, 2026 16:39
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch 2 times, most recently from 7753d07 to 6173ed9 Compare February 9, 2026 16:55
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from 83e6108 to af2608a Compare February 9, 2026 16:55
@i1skn i1skn changed the base branch from 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector to graphite-base/7107 February 9, 2026 16:59
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch from 6173ed9 to f634984 Compare February 10, 2026 15:58
@i1skn i1skn force-pushed the graphite-base/7107 branch 2 times, most recently from 212a07b to d682a52 Compare February 10, 2026 16:54
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch from f634984 to 0d8074f Compare February 10, 2026 16:54
@i1skn i1skn changed the base branch from graphite-base/7107 to 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector February 10, 2026 16:54
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from d682a52 to 3670c7d Compare February 10, 2026 17:38
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch from 0d8074f to a2213ac Compare February 10, 2026 17:38
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch 2 times, most recently from bf3e87c to 08928b4 Compare February 10, 2026 19:35
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch from a2213ac to dddec36 Compare February 10, 2026 19:35
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from 08928b4 to 957d7c4 Compare February 11, 2026 15:50
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch from dddec36 to 21dcc49 Compare February 11, 2026 15:50
@i1skn i1skn changed the base branch from 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector to graphite-base/7107 February 12, 2026 12:31
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch from 21dcc49 to 59a233a Compare February 12, 2026 12:32
@i1skn i1skn force-pushed the graphite-base/7107 branch from 957d7c4 to 2871ee5 Compare February 12, 2026 12:32
@graphite-app graphite-app Bot changed the base branch from graphite-base/7107 to develop February 12, 2026 12:32
@i1skn i1skn force-pushed the 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ branch from 59a233a to 3f65aa3 Compare February 12, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@i1skn