Skip to content

feat: add search header to perps/prediction flows token selector#7098

Merged
i1skn merged 1 commit intodevelopfrom
02-06-feat_add_search_header_to_perps_prediction_flows_token_selector
Feb 12, 2026
Merged

feat: add search header to perps/prediction flows token selector#7098
i1skn merged 1 commit intodevelopfrom
02-06-feat_add_search_header_to_perps_prediction_flows_token_selector

Conversation

@i1skn
Copy link
Copy Markdown
Contributor

@i1skn i1skn commented Feb 6, 2026

Adds search functionality to the Deposit screen

Fixes APP-3118
Fixes APP-3438

What changed (plus any additional context for devs)

  • Added a third navigation state: SEARCH_FOCUSED (alongside input/token-list states).
  • Moved navigation step definitions into shared funding constants for reuse.
  • Added an in-list token search header with focus/cancel/close handling.
  • Updated token-list overlay visibility logic so it remains visible for both token-list and search-focused states.
  • Hid the sheet handle/navbar while search is focused and updated container animation/layout for that state.
  • Added list footer spacing adjustments to prevent clipping when search is focused.

Screen recordings / screenshots

Android iOS
Screen Recording 2026-02-09 at 17.43.24.mov (uploaded via Graphite) Simulator Screen Recording - iPhone 17 Pro - 2026-02-09 at 17.42.25.mov (uploaded via Graphite)

What to test

  • Open token selector from perps/prediction deposit and swap flow and confirm the search header is present.
  • Focus search and verify navbar/handle transition out and layout animates into search state.
  • Type queries and verify token results filter correctly.
  • Tap cancel/close from search and verify state returns to token-list (or input when appropriate).
  • Select a token from filtered/unfiltered results and verify it is applied and focus state resets correctly.
  • Verify iOS and Android keyboard/safe-area behavior (no overlap, clipping, or broken scrolling).

@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from 36b71b7 to 8221f50 Compare February 6, 2026 14:13
@i1skn i1skn force-pushed the 02-05-chrore_extract_token_search_input_and_button branch 2 times, most recently from aadcd11 to 8af25b3 Compare February 6, 2026 16:18
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from 8221f50 to 3988e23 Compare February 6, 2026 16:18
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from 3988e23 to a531e76 Compare February 6, 2026 16:24
@i1skn i1skn force-pushed the 02-05-chrore_extract_token_search_input_and_button branch 2 times, most recently from f522b25 to c7c4643 Compare February 6, 2026 16:26
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch 2 times, most recently from 7ceb0c6 to 321d978 Compare February 6, 2026 18:04
@i1skn i1skn force-pushed the 02-05-chrore_extract_token_search_input_and_button branch from c7c4643 to e1cd85d Compare February 6, 2026 18:04
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from 321d978 to a8a8628 Compare February 6, 2026 20:34
@i1skn i1skn force-pushed the 02-05-chrore_extract_token_search_input_and_button branch from e1cd85d to bf0335c Compare February 6, 2026 20:34
@i1skn i1skn changed the base branch from 02-05-chrore_extract_token_search_input_and_button to graphite-base/7098 February 6, 2026 20:41
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from a8a8628 to 9bbc262 Compare February 6, 2026 20:41
@i1skn i1skn changed the base branch from graphite-base/7098 to 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ February 6, 2026 20:42
@i1skn i1skn changed the base branch from 02-06-fix_android_add_gap_between_token_list_sheet_and_keyboard_app-3442_ to graphite-base/7098 February 6, 2026 20:52
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from 9bbc262 to e5f5d04 Compare February 6, 2026 20:53
@i1skn i1skn force-pushed the graphite-base/7098 branch from 2e69569 to bf0335c Compare February 6, 2026 20:53
@i1skn i1skn changed the base branch from graphite-base/7098 to 02-05-chrore_extract_token_search_input_and_button February 6, 2026 20:53
@i1skn i1skn force-pushed the 02-05-chrore_extract_token_search_input_and_button branch from bf0335c to ca32478 Compare February 9, 2026 12:38
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch 2 times, most recently from 87180c9 to bd555dd Compare February 9, 2026 14:34
@i1skn i1skn force-pushed the 02-05-chrore_extract_token_search_input_and_button branch 2 times, most recently from 85ced13 to 9914c1c Compare February 9, 2026 16:34
@i1skn i1skn requested review from maxbbb and olerass February 9, 2026 17:00
@i1skn i1skn marked this pull request as ready for review February 9, 2026 17:00
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2026

🧪 Flashlight Performance Report (AWS Device Farm)

🔀 Commit: 4ef5af2

📎 View Artifacts

Metric Current Δ vs Baseline
Time to Interactive (TTI) 5552 ms 🔴 +108.2 ms (+2.0%)
Average FPS 56.74 ⚪ -0.1 (-0.2%)
Average RAM 388.8 MB 🟢 -11.6 MB (-2.9%)

Copy link
Copy Markdown
Contributor

@maxbbb maxbbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice.

Comment thread src/systems/funding/components/deposit/SearchInput.tsx Outdated
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from c16ee48 to 212a07b Compare February 10, 2026 15:58
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for 90d52f0

@i1skn i1skn force-pushed the 02-05-chrore_extract_token_search_input_and_button branch from ef30149 to c6e2bde Compare February 10, 2026 16:54
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from 212a07b to d682a52 Compare February 10, 2026 16:54
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for d1846e1

@i1skn i1skn force-pushed the 02-05-chrore_extract_token_search_input_and_button branch 2 times, most recently from 485c252 to 7b2c046 Compare February 10, 2026 17:38
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from d682a52 to 3670c7d Compare February 10, 2026 17:38
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for 4901c63

@i1skn i1skn changed the base branch from 02-05-chrore_extract_token_search_input_and_button to graphite-base/7098 February 10, 2026 19:34
@i1skn i1skn force-pushed the graphite-base/7098 branch from 7b2c046 to a81824f Compare February 10, 2026 19:34
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from 3670c7d to bf3e87c Compare February 10, 2026 19:34
@graphite-app graphite-app Bot changed the base branch from graphite-base/7098 to develop February 10, 2026 19:35
@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from bf3e87c to 08928b4 Compare February 10, 2026 19:35
@github-actions
Copy link
Copy Markdown

Launch in simulator or device for b972635

Copy link
Copy Markdown
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only seeing two things in comparison to swaps:

  1. On Android devices, when you focus into the search input field and then tap the All networks button the keyboard doesn't dismiss.

Comparison between swaps and perp/prediction search
https://github.com/user-attachments/assets/23a51f7e-9dd8-4ec7-addd-af386ee31dbe

  1. When searching text in swaps that don't exist as a token we show the Nothing found message, however we do not show that in the perps/predictions search, do we need to/want to?
screen-20260210-190354-1770768218024.mp4

@i1skn i1skn force-pushed the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch from 08928b4 to 957d7c4 Compare February 11, 2026 15:50
Copy link
Copy Markdown
Contributor Author

i1skn commented Feb 11, 2026

@ibrahimtaveras00 great finding! I've fixed those, PTAL

untitled.webm (uploaded via Graphite)

@github-actions
Copy link
Copy Markdown

Launch in simulator or device for 4ef5af2

Copy link
Copy Markdown
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good on both OS's, QA Passed 👍🏽

@i1skn i1skn merged commit 2871ee5 into develop Feb 12, 2026
19 checks passed
@i1skn i1skn deleted the 02-06-feat_add_search_header_to_perps_prediction_flows_token_selector branch February 12, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants