Skip to content

Fix class name collision in CardBuilder DSL causing flaky specs #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix class name collision in CardBuilder DSL causing flaky specs #513

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3bb784
Initial plan
Copilot Jan 6, 2026
cf65710
Fix flaky spec by renaming conflicting PowerAndToughnessModification …
Copilot Jan 6, 2026
bee757e
Reopen classes after DSL to properly scope nested classes
Copilot Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/magic/cards/righteous_valkyrie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module Cards
toughness 4
keywords :flying

class PowerAndToughnessModification < Abilities::Static::PowerAndToughnessModification
class RighteousValkyriePowerAndToughnessModification < Abilities::Static::PowerAndToughnessModification
# As long as you have at least 7 life more than your starting life total...
conditions do
t = controller.life >= controller.starting_life + 7
Expand All @@ -18,7 +18,7 @@ class PowerAndToughnessModification < Abilities::Static::PowerAndToughnessModifi
modify power: 2, toughness: 2
end

def static_abilities = [PowerAndToughnessModification]
def static_abilities = [RighteousValkyriePowerAndToughnessModification]

class AngelOrClericEnters < TriggeredAbility::EnterTheBattlefield
def should_perform?
Expand Down
4 changes: 2 additions & 2 deletions lib/magic/cards/rousing_read.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ class KeywordGrantFlying < Abilities::Static::KeywordGrant
applies_to_target
end

class PowerAndToughnessModification < Abilities::Static::PowerAndToughnessModification
class RousingReadPowerAndToughnessModification < Abilities::Static::PowerAndToughnessModification
modify power: 1, toughness: 1
applies_to_target
end

def static_abilities
[KeywordGrantFlying, PowerAndToughnessModification]
[KeywordGrantFlying, RousingReadPowerAndToughnessModification]
end
end
end
Expand Down