Fix class name collision in CardBuilder DSL causing flaky specs

[Copilot]

Nested classes defined within CardBuilder DSL blocks were colliding at the Magic::Cards module level, causing test flakiness where one card's logic would override another's.

Root Cause

When using Creature("Name") do ... end, the block is evaluated via Class.new(base_class, &block). Ruby constant lookup rules place nested class definitions at the enclosing module level (Magic::Cards) rather than inside the anonymous class:

# Both define Magic::Cards::PowerAndToughnessModification
RighteousValkyrie = Creature("Righteous Valkyrie") do
  class PowerAndToughnessModification < Abilities::Static::PowerAndToughnessModification
    conditions do
      controller.life >= controller.starting_life + 7
    end
  end
end

RousingRead = Aura("Rousing Read") do
  class PowerAndToughnessModification < Abilities::Static::PowerAndToughnessModification
    # No conditions - should always apply
    # But inherits RighteousValkyrie's condition due to collision
  end
end

Load order determined which card's class definition "won", causing non-deterministic test failures.

Solution

Following the established pattern from cards like CanopyTactician, ElvishArchdruid, and GloriousAnthem, the fix separates the CardBuilder DSL from class definitions:

1. Use CardBuilder DSL for basic card setup (cost, types, power/toughness, etc.)
2. Reopen the class with explicit inheritance (e.g., class RighteousValkyrie < Creature)
3. Define nested classes inside the reopened class

This ensures nested classes are properly scoped to Magic::Cards::RighteousValkyrie::PowerAndToughnessModification instead of Magic::Cards::PowerAndToughnessModification, preventing collisions while maintaining consistent naming conventions across the codebase.

Example:

RighteousValkyrie = Creature("Righteous Valkyrie") do
  cost generic: 2, white: 1
  # ... basic setup
end

class RighteousValkyrie < Creature
  class PowerAndToughnessModification < Abilities::Static::PowerAndToughnessModification
    # Properly scoped to Magic::Cards::RighteousValkyrie::PowerAndToughnessModification
  end
end

Original prompt

Work on TODO: Fix this flaky spec, it fails when all the tests are run. Why is that? (from spec/cards/righteous_valkyrie_spec.rb)

Created from VS Code via the GitHub Pull Request extension.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[radar]

No, reopen the classes after the DSL part and keep the class names consistent across both.

[radar]

No, reopen the classes after the DSL part and keep the class names consistent across both.

[Copilot]

No, reopen the classes after the DSL part and keep the class names consistent across both.

...

Done in bee757e. Both cards now reopen their classes after the DSL part, following the pattern used in CanopyTactician, ElvishArchdruid, and GloriousAnthem. The nested classes maintain their original names (PowerAndToughnessModification) and are properly scoped to Magic::Cards::CardName::PowerAndToughnessModification.

No, reopen the classes after the DSL part and keep the class names consistent across both.

Done in bee757e. Both cards now reopen their classes after the DSL part, following the pattern used in CanopyTactician, ElvishArchdruid, and GloriousAnthem. The nested classes maintain their original names (PowerAndToughnessModification) and are properly scoped to Magic::Cards::CardName::PowerAndToughnessModification.