Resolve IE TLS GOT entries statically in PIE#1208
Open
quic-areg wants to merge 1 commit into
Open
Conversation
quic-areg
changed the title
parth-07
reviewed
Jun 1, 2026
For non-preemptible symbols accessed through R_*_GOTTPOFF / R_*_TLS_IE, the IE-mode GOT entry was being initialized with a dynamic TPREL/TPOFF relocation in any non-static link, including -pie. PIE executables are not preempted, so the static TLS offset is known at link time and a dynamic relocation is both unnecessary and rejected by the loader. Also set `DF_STATIC_TLS` on AArch64, ARM, and RISCV (Hexagon and X86 already do). Fixes: qualcomm#1110 Signed-off-by: quic-areg <aregmi@qti.qualcomm.com>
Contributor
quic-seaswara
left a comment
quic-seaswara
left a comment
There was a problem hiding this comment.
Can we also add a build/run test to make sure that the values printed are consistent and match expectations ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For non-preemptible symbols accessed through
R_*_GOTTPOFF / R_*_TLS_IE, the IE-mode GOT entry was being initialized with a dynamic TPREL/TPOFF relocation in any non-static link, including -pie. PIE executables are not preempted, so the static TLS offset is known at link time and a dynamic relocation is both unnecessary and rejected by the loader.Also set
DF_STATIC_TLSon AArch64, ARM, and RISCV (Hexagon and X86 already do).Fixes #1110