[X86] Emit R_X86_64_TPOFF64 for IE-mode TLS in shared objects.#1207
Merged
Conversation
quic-seaswara
requested changes
May 22, 2026
Contributor
quic-seaswara
left a comment
quic-seaswara
left a comment
There was a problem hiding this comment.
It would be good to add a build and run test to make sure that the executable / shared object returns the value that we are looking for.
I posted this here
For IE TLS, x86_64 accesses a GOT entry containing the symbol's offset from the thread pointer. For executable outputs, the TP offset is fixed at link time, so the GOT entry can be resolved statically. For shared objects, the offset is assigned by the dynamic loader. ELD was still writing the link-time static TLS offset into the GOT entry for local IE TLS references, leaving no dynamic relocation for the loader to apply. Emit `R_X86_64_TPOFF64` for IE TLS GOT entries in shared objects, and mark the output with `DF_STATIC_TLS` when static TLS is required. Keep PIE output statically resolved. Signed-off-by: quic-areg <aregmi@qti.qualcomm.com>
quic-seaswara
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For IE TLS, x86_64 accesses a GOT entry containing the symbol's offset from the thread pointer. For executable outputs, the TP offset is fixed at link time, so the GOT entry can be resolved statically.
For shared objects, the offset is assigned by the dynamic loader. ELD was still writing the link-time static TLS offset into the GOT entry for local IE TLS references, leaving no dynamic relocation for the loader to apply.
Emit
R_X86_64_TPOFF64for IE TLS GOT entries in shared objects, and mark the output withDF_STATIC_TLSwhen static TLS is required. Keep PIE output statically resolved.