Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conf/machine/iq-615-evk.conf
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += " \
packagegroup-iq-615-evk-firmware \
packagegroup-iq-615-evk-hexagon-dsp-binaries \
qairt-sdk-hexagon-v66 \
qcom-fastcv-binaries-qcs615-ride-dsp \
qps615-dlkm \
"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ LICENSE = "LICENSE.qcom-2"
LIC_FILES_CHKSUM = "file://${UNPACKDIR}/usr/share/doc/${PN}/NOLOGINBINARYLICENSEQTI.pdf;md5=4ceffe94cb40cdce6d2f4fb93cc063d1 \
file://${UNPACKDIR}/usr/share/doc/${PN}/NOTICE;md5=4b722aa0574e24873e07b94e40b92e4d "

PBT_BUILD_DATE = "260422"
ARTIFACTORY_URL = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/computervision-fastcv.qclinux.0.1/${PBT_BUILD_DATE}/prebuilt_yocto"
PBT_ARCH = "armv8a"
PBT_BUILD_DATE = "260624.1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qcom-fastcv-binaries: Added bug fixes in FastCV DSP libs

No, you are not adding bugfixes. You are upgrading fastcv to a new release. Also please drop the bullet list from the commit message and write the English text.

ARTIFACTORY_URL = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/computervision-fastcv.qclinux.0.1/${PBT_BUILD_DATE}/prebuilt_yocto_master"
PBT_ARCH = "armv8-6a"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with the other machines which are not ARMv8.6-A? Will they generate unknown instruction segfaults?


SRC_URI = "${ARTIFACTORY_URL}/${BPN}_${PV}_${PBT_ARCH}.tar.gz"
SRC_URI[sha256sum] = "bcaa974b97b4e9ec09edf1843dc821dd01bf0cfe6953c93de447064bf8898b56"
SRC_URI[sha256sum] = "831edddfe6c1df285949c6722f406b4a4633913c30a9b7f02787c4405e1dde2d"
S = "${UNPACKDIR}"

DEPENDS += "glib-2.0 fastrpc"
Expand All @@ -30,6 +30,7 @@ do_install() {
install -d ${D}${datadir}/qcom/qcs615/Qualcomm/QCS615-RIDE/dsp/cdsp
install -d ${D}${datadir}/qcom/qcs8300/Qualcomm/QCS8300-RIDE/dsp/cdsp
install -d ${D}${datadir}/qcom/sa8775p/Qualcomm/SA8775P-RIDE/dsp/cdsp
install -d ${D}${datadir}/qcom/shikra/Qualcomm/Shikra-CQS-EVK/dsp/cdsp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qcom-fastcv-binaries: add FastCV DSP support for Shikra Target

There is no Shikra target. You are adding support for one of the boards.

install -d ${D}${datadir}/qcom/sm8750/Qualcomm/SM8750-MTP/dsp/cdsp
install -d ${D}${datadir}/qcom/x1e80100/Qualcomm/Hamoa-IoT-EVK/dsp/cdsp

Expand All @@ -46,14 +47,15 @@ do_install() {
install -m 0644 ${S}/usr/include/fastcv/fastcv.h ${D}${includedir}/fastcv/
install -m 0644 ${S}/usr/include/fastcv/fastcvExt.h ${D}${includedir}/fastcv/

install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v68/KODIAK/*.so ${D}${datadir}/qcom/qcm6490/Thundercomm/RB3gen2/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v65/TALOS_MOOREA/*.so ${D}${datadir}/qcom/qcs615/Qualcomm/QCS615-RIDE/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v75/MONACO/*.so ${D}${datadir}/qcom/qcs8300/Qualcomm/QCS8300-RIDE/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v66/SHIKRA/*.so ${D}${datadir}/qcom/shikra/Qualcomm/Shikra-CQS-EVK/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v68/KODIAK/*.so ${D}${datadir}/qcom/qcm6490/Thundercomm/RB3gen2/dsp/cdsp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mix upgrades and refactors. Split reordering to a separate commit (maybe before version upgrade).

install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v73/HAMOA/*.so ${D}${datadir}/qcom/x1e80100/Qualcomm/Hamoa-IoT-EVK/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v73/LEMANS/*.so ${D}${datadir}/qcom/sa8775p/Qualcomm/SA8775P-RIDE/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v75/MONACO/*.so ${D}${datadir}/qcom/qcs8300/Qualcomm/QCS8300-RIDE/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v79/PAKALA/*.so ${D}${datadir}/qcom/sm8750/Qualcomm/SM8750-MTP/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v81/KAANAPALI/*.so ${D}${datadir}/qcom/kaanapali/Qualcomm/Kaanapali-MTP/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v81/GLYMUR/*.so ${D}${datadir}/qcom/glymur/Qualcomm/Glymur-CRD/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v81/GLYMUR/*.so ${D}${datadir}/qcom/glymur/Qualcomm/Glymur-CRD/dsp/cdsp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace changes can go with the reorder.


install -m 0755 ${S}/usr/bin/fastcv_simple_test64 ${D}${bindir}
}
Expand All @@ -68,6 +70,7 @@ PACKAGES += "\
${PN}-qcs615-ride-dsp \
${PN}-qcs8300-ride-dsp \
${PN}-sa8775p-ride-dsp \
${PN}-shikra-cqs-evk-dsp \
${PN}-sm8750-mtp-dsp \
${PN}-thundercomm-rb3gen2-dsp \
"
Expand All @@ -82,6 +85,7 @@ RDEPENDS:${PN}-purwa-iot-evk-dsp = "${PN}-dsp ${PN}-hamoa-iot-evk-dsp"
RDEPENDS:${PN}-qcs615-ride-dsp = "${PN}-dsp"
RDEPENDS:${PN}-qcs8300-ride-dsp = "${PN}-dsp"
RDEPENDS:${PN}-sa8775p-ride-dsp = "${PN}-dsp"
RDEPENDS:${PN}-shikra-cqs-evk-dsp = "${PN}-dsp"
RDEPENDS:${PN}-sm8750-mtp-dsp = "${PN}-dsp"
RDEPENDS:${PN}-thundercomm-rb3gen2-dsp = "${PN}-dsp"

Expand All @@ -91,6 +95,7 @@ INSANE_SKIP:${PN}-kaanapali-mtp-dsp = "arch libdir"
INSANE_SKIP:${PN}-qcs615-ride-dsp = "arch libdir"
INSANE_SKIP:${PN}-qcs8300-ride-dsp = "arch libdir"
INSANE_SKIP:${PN}-sa8775p-ride-dsp = "arch libdir"
INSANE_SKIP:${PN}-shikra-cqs-evk-dsp = "arch libdir"
INSANE_SKIP:${PN}-sm8750-mtp-dsp = "arch libdir"
INSANE_SKIP:${PN}-thundercomm-rb3gen2-dsp = "arch libdir"

Expand All @@ -103,5 +108,6 @@ FILES:${PN}-kaanapali-mtp-dsp += "${datadir}/qcom/kaanapali/Qualcomm/Kaanapali-M
FILES:${PN}-qcs615-ride-dsp += "${datadir}/qcom/qcs615/Qualcomm/QCS615-RIDE/dsp"
FILES:${PN}-qcs8300-ride-dsp += "${datadir}/qcom/qcs8300/Qualcomm/QCS8300-RIDE/dsp"
FILES:${PN}-sa8775p-ride-dsp += "${datadir}/qcom/sa8775p/Qualcomm/SA8775P-RIDE/dsp"
FILES:${PN}-shikra-cqs-evk-dsp += "${datadir}/qcom/shikra/Qualcomm/Shikra-CQS-EVK/dsp/cdsp"
FILES:${PN}-sm8750-mtp-dsp += "${datadir}/qcom/sm8750/Qualcomm/SM8750-MTP/dsp/cdsp"
FILES:${PN}-thundercomm-rb3gen2-dsp += "${datadir}/qcom/qcm6490/Thundercomm/RB3gen2/dsp"
Loading