Skip to content

Enable FastCV DSP packages for Shikra and IQ-615-EVK targets#2648

Open
quic-ptak wants to merge 3 commits into
qualcomm-linux:masterfrom
quic-ptak:master
Open

Enable FastCV DSP packages for Shikra and IQ-615-EVK targets#2648
quic-ptak wants to merge 3 commits into
qualcomm-linux:masterfrom
quic-ptak:master

Conversation

@quic-ptak

Copy link
Copy Markdown
Contributor
  • Added FastCV DSP support in machine configurations for: Shikra and IQ-615-EVK
  • Update install rules and package definitions for target platforms
  • Updated HAP power APIs to make power voting target-agnostic
  • Updated Lemans DSP libraries generated with Hexagon SDK v8.7.10.1.
  • Bump package version.

 - Updated HAP power APIs to make power voting target-agnostic.
 - Updated Lemans DSP libraries geberated with Hexagon SDK v8.7.10.1.
 - Bumped up recipe version.

Signed-off-by: Pulkit Singh Tak <ptak@qti.qualcomm.com>
 - Add DSP skel libraries for Shikra target to enable FastCV DSP functionality.
 - Update install rules and package definitions for corresponding targets

Signed-off-by: Pulkit Singh Tak <ptak@qti.qualcomm.com>
Add FastCV DSP support for iq-615-evk target.

Signed-off-by: Pulkit Singh Tak <ptak@qti.qualcomm.com>
PBT_BUILD_DATE = "260422"
ARTIFACTORY_URL = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/computervision-fastcv.qclinux.0.1/${PBT_BUILD_DATE}/prebuilt_yocto"
PBT_ARCH = "armv8a"
PBT_BUILD_DATE = "260624.1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qcom-fastcv-binaries: Added bug fixes in FastCV DSP libs

No, you are not adding bugfixes. You are upgrading fastcv to a new release. Also please drop the bullet list from the commit message and write the English text.

PBT_ARCH = "armv8a"
PBT_BUILD_DATE = "260624.1"
ARTIFACTORY_URL = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/computervision-fastcv.qclinux.0.1/${PBT_BUILD_DATE}/prebuilt_yocto_master"
PBT_ARCH = "armv8-6a"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with the other machines which are not ARMv8.6-A? Will they generate unknown instruction segfaults?

install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v68/KODIAK/*.so ${D}${datadir}/qcom/qcm6490/Thundercomm/RB3gen2/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v65/TALOS_MOOREA/*.so ${D}${datadir}/qcom/qcs615/Qualcomm/QCS615-RIDE/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v75/MONACO/*.so ${D}${datadir}/qcom/qcs8300/Qualcomm/QCS8300-RIDE/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v68/KODIAK/*.so ${D}${datadir}/qcom/qcm6490/Thundercomm/RB3gen2/dsp/cdsp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mix upgrades and refactors. Split reordering to a separate commit (maybe before version upgrade).

install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v79/PAKALA/*.so ${D}${datadir}/qcom/sm8750/Qualcomm/SM8750-MTP/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v81/KAANAPALI/*.so ${D}${datadir}/qcom/kaanapali/Qualcomm/Kaanapali-MTP/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v81/GLYMUR/*.so ${D}${datadir}/qcom/glymur/Qualcomm/Glymur-CRD/dsp/cdsp
install -m 0644 ${S}/usr/lib/dsp/cdsp/cv/v81/GLYMUR/*.so ${D}${datadir}/qcom/glymur/Qualcomm/Glymur-CRD/dsp/cdsp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace changes can go with the reorder.

install -d ${D}${datadir}/qcom/qcs615/Qualcomm/QCS615-RIDE/dsp/cdsp
install -d ${D}${datadir}/qcom/qcs8300/Qualcomm/QCS8300-RIDE/dsp/cdsp
install -d ${D}${datadir}/qcom/sa8775p/Qualcomm/SA8775P-RIDE/dsp/cdsp
install -d ${D}${datadir}/qcom/shikra/Qualcomm/Shikra-CQS-EVK/dsp/cdsp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qcom-fastcv-binaries: add FastCV DSP support for Shikra Target

There is no Shikra target. You are adding support for one of the boards.

@github-actions

Copy link
Copy Markdown

Test run workflow

Test jobs for commit 1d64d89

nodistro
Pass: 10 | Fail: 0 | Total: 10
qcom-distro_linux-qcom-6.18
Pass: 225 | Fail: 0 | Total: 254
qcom-distro
Pass: 268 | Fail: 0 | Total: 301

@test-reporting-app

Copy link
Copy Markdown

Test Results

  110 files  ±0    657 suites  ±0   7h 14m 16s ⏱️ - 52m 56s
  162 tests +3    148 ✅ +4   2 💤 ±0  12 ❌  -  1 
6 250 runs   - 7  6 170 ✅  - 5  66 💤 +9  14 ❌  - 11 

For more details on these failures, see this check.

Results for commit 1d64d89. ± Comparison against base commit e261022.

@ricardosalveti

Copy link
Copy Markdown
Contributor

Shikra is now merged, rebase and update (include the review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants