Skip to content

Avoid stack overflow in PyStringCache#239

Merged
Viicos merged 2 commits intomainfrom
vp/string-cache-stackoverflow
Apr 8, 2026
Merged

Avoid stack overflow in PyStringCache#239
Viicos merged 2 commits intomainfrom
vp/string-cache-stackoverflow

Conversation

@Viicos
Copy link
Copy Markdown
Member

@Viicos Viicos commented Apr 3, 2026

Fixes #238.

Can confirm this fixes the reported pydantic issue.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/jiter/src/py_string_cache.rs 60.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 3, 2026

Merging this PR will not alter performance

✅ 70 untouched benchmarks


Comparing vp/string-cache-stackoverflow (a93a5ec) with main (8ece8a4)

Open in CodSpeed

@Viicos
Copy link
Copy Markdown
Member Author

Viicos commented Apr 3, 2026

@davidhewitt no idea how to handle coverage here: codecov is broken (HTTP 400), and I get completely different coverage results locally.. The setup should ideally be improved.

@samuelcolvin
Copy link
Copy Markdown
Member

coverage doesn't matter. But let @davidhewitt review the change.

@Viicos Viicos merged commit b14af5e into main Apr 8, 2026
25 of 26 checks passed
@Viicos Viicos deleted the vp/string-cache-stackoverflow branch April 8, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stack overflow under musl in PyStringCache::default()

4 participants