Skip to content

docs: unify gateway_server naming in architecture docs#150

Closed
kooksee wants to merge 1 commit into
v2from
docs/gateway-server-unify
Closed

docs: unify gateway_server naming in architecture docs#150
kooksee wants to merge 1 commit into
v2from
docs/gateway-server-unify

Conversation

@kooksee

@kooksee kooksee commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • 主架构文档统一为 gatewayserver + gateway_servergrpcs / grpc_server 仅保留在 Legacy 迁移小节或 docs/legacy-removal.md
  • 更新 deploy/traefikpkg/gateway/docs 示例 YAML 与端口配置项说明
  • 修正 design-v2 / copilot 指引中的 pkg/lava 路径;grpc_passthrough 默认说明与代码一致(true
  • 勾选 legacy-removal.md 中「架构文档仅描述 gateway_server」

Test plan

  • 文档 diff 审阅,无运行时代码变更
  • 合并后确认 docs/modules/servers.mdarchitecture-v2.md 渲染正常

Made with Cursor

Main docs now describe gatewayserver and gateway_server; grpcs/grpc_server
appear only in legacy migration sections. Updates Traefik examples and
pkg/gateway doc YAML samples; marks legacy-removal checklist item done.

Co-authored-by: Cursor <cursoragent@cursor.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project documentation and deployment configurations to reflect the deprecation and removal of the legacy grpcs package and the migration of configuration keys from grpc_server to gateway_server. Feedback was provided to maintain language consistency in the Copilot instructions file by translating a Chinese parenthetical note into English.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.


Place new code by responsibility:
- Cross-protocol abstractions -> `lava/`
- Cross-protocol abstractions -> `pkg/lava/`(根 `lava/` 仅为 deprecated shim)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

.github/copilot-instructions.md 整体是英文文档,第 17 行混入了中文括号和说明 (根 lava/ 仅为 deprecated shim)。为了保持文档语言的一致性,建议将其统一为英文,例如 (root lava/ is only a deprecated shim)

@kooksee

kooksee commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #152 (rebased after #151 removed , keeping docs aligned with current v2 state).

@kooksee kooksee closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant