Allow DialogOverlay to display custom dialogs#37638
Open
LiquidPL wants to merge 2 commits intoppy:masterfrom
Open
Allow DialogOverlay to display custom dialogs#37638LiquidPL wants to merge 2 commits intoppy:masterfrom
DialogOverlay to display custom dialogs#37638LiquidPL wants to merge 2 commits intoppy:masterfrom
Conversation
LiquidPL
added a commit
to LiquidPL/osu
that referenced
this pull request
May 6, 2026
Following up from ppy#37638, this commit refactors `ReportPopover` and friends to instead use `PopupDialog` and `DialogOverlay`. This results in the report forms being always placed in the center of the screen, instead of being anchored at whatever drawable happened to spawn it.
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prerequisite for refactoring
ReportPopovers into dialog popups. This initially came to be while I was working on #36335, which needed some ugly hacks to be able to be triggered from an already visible popover. The idea behind this PR is to rework said report popovers into fullscreen dialogs based onDialogOverlay, because in most of the cases it is displayed it feels kinda weird for it to be parented to whatever drawable it was spawned from, and also it's a different behaviour from web, which would always display those as screen centered dialogs.This PR is split into two commits to reduce the per commit diff size:
PopupDialogtoButtonPopupDialog, which is going to contain all the logic surrounding the current dialogs,PopupDialogclass.A follow-up PR will handle refactoring the
ReportPopovers to use the newPopupDialog, although I'm not sure if this should happen before or after #36335 is merged.