Refactor report popovers to use dialogs#37647
Open
LiquidPL wants to merge 5 commits intoppy:masterfrom
Open
Conversation
Following up from ppy#37638, this commit refactors `ReportPopover` and friends to instead use `PopupDialog` and `DialogOverlay`. This results in the report forms being always placed in the center of the screen, instead of being anchored at whatever drawable happened to spawn it.
Member
|
Hmm, I kind of liked them being popovers but sure. The does expose the shortcoming of popup dialogs not dimming other overlays behind them, though. Probably just need to ignore perf concerns and add a dim layer in the popover manager class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #37638.
Following up from #37638, this commit refactors
ReportPopoverandfriends to instead use
PopupDialogandDialogOverlay. This resultsin the report forms being always placed in the center of the screen,
instead of being anchored at whatever drawable happened to spawn it.
The bulk of the diff here is renaming
ReportPopovertoReportDialogalongside the necessary refactors, which made git treat them as separate
files instead of a rename. I could have tried to isolate the rename to its own
commit, but this is already convoluted enough. The rest of the diff is fairly
small and revolves mostly around updating the derived report dialog classes
and tests.
This will be used in a future PR to implement reporting in ranked play,
which wouldn't look good with the current popover approach.
Some demos:
Screencast_20260506_003355.webm
Screencast_20260506_003449.webm
Screencast_20260506_004047.webm