fix(status-area): don't panic when SNI signal streams fail to initialize #1425
+35
−12
Annotations
10 warnings
|
Run actions-rs-plus/clippy-check@v2:
cosmic-app-list/src/app.rs#L179
warning: this function has too many arguments (10/7)
--> cosmic-app-list/src/app.rs:179:5
|
179 | / fn as_icon(
180 | | &self,
181 | | applet: &Context,
182 | | rectangle_tracker: Option<&RectangleTracker<DockItemId>>,
... |
189 | | filter: Option<&dyn Fn(&ToplevelInfo) -> bool>,
190 | | ) -> Element<'_, Message> {
| |_____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-app-list/src/app.rs#L414
warning: variants `StartListeningForDnd` and `StopListeningForDnd` are never constructed
--> cosmic-app-list/src/app.rs:414:5
|
388 | enum Message {
| ------- variants in this enum
...
414 | StartListeningForDnd,
| ^^^^^^^^^^^^^^^^^^^^
415 | StopListeningForDnd,
| ^^^^^^^^^^^^^^^^^^^
|
= note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-bluetooth/src/bluetooth.rs#L794
warning: this `else { if .. }` block can be collapsed
--> cosmic-applet-bluetooth/src/bluetooth.rs:794:40
|
794 | ... } else {
| ______________________________^
795 | | ... if let Err(err) = device.set_trusted(true).await {
796 | | ... tracing::error!(?err, "Failed to trust device.");
797 | | ... }
798 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_else_if
help: collapse nested if block
|
794 ~ } else if let Err(err) = device.set_trusted(true).await {
795 + tracing::error!(?err, "Failed to trust device.");
796 + }
|
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-bluetooth/src/bluetooth.rs#L779
warning: this `else { if .. }` block can be collapsed
--> cosmic-applet-bluetooth/src/bluetooth.rs:779:40
|
779 | ... } else {
| ______________________________^
780 | | ... if let Err(err) = device.set_trusted(true).await {
781 | | ... tracing::error!(?err, "Failed to trust device.");
782 | | ... }
783 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
779 ~ } else if let Err(err) = device.set_trusted(true).await {
780 + tracing::error!(?err, "Failed to trust device.");
781 + }
|
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-bluetooth/src/bluetooth.rs#L737
warning: this `if` statement can be collapsed
--> cosmic-applet-bluetooth/src/bluetooth.rs:737:29
|
737 | / ... if let Some(id) = tokio::process::Command::new("rfkill")
738 | | ... .env("PATH", rfkill_path_var())
739 | | ... .arg("list")
740 | | ... .arg("-n")
... |
765 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
help: collapse nested if block
|
752 ~ })
753 ~ && let Err(err) = tokio::process::Command::new("rfkill")
754 | .env("PATH", rfkill_path_var())
...
762 | );
763 ~ }
|
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-bluetooth/src/bluetooth.rs#L100
warning: this `if` statement can be collapsed
--> cosmic-applet-bluetooth/src/bluetooth.rs:100:21
|
100 | / if let Ok(session) = Session::new().await {
101 | | if let Ok(state) = BluerSessionState::new(session).await {
102 | | break state;
103 | | }
104 | | }
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
100 ~ if let Ok(session) = Session::new().await
101 ~ && let Ok(state) = BluerSessionState::new(session).await {
102 | break state;
103 ~ }
|
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-bluetooth/src/app.rs#L78
warning: variant `Surface` is never constructed
--> cosmic-applet-bluetooth/src/app.rs:78:5
|
66 | enum Message {
| ------- variant in this enum
...
78 | Surface(surface::Action),
| ^^^^^^^
|
= note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-bluetooth/src/app.rs#L148
warning: unused variable: `req`
--> cosmic-applet-bluetooth/src/app.rs:148:21
|
148 | req,
| ^^^ help: try ignoring the field: `req: _`
|
= note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-bluetooth/src/bluetooth.rs#L153
warning: unreachable pattern
--> cosmic-applet-bluetooth/src/bluetooth.rs:153:25
|
153 | _ => return,
| ^ no value can reach this
|
note: multiple earlier patterns match some of the same values
--> cosmic-applet-bluetooth/src/bluetooth.rs:153:25
|
137 | BluerSessionEvent::ChangesProcessed(state) => {
| ------------------------------------------ matches some of the same values
...
141 | / BluerSessionEvent::RequestResponse {
142 | | req,
143 | | state,
144 | | err_msg,
145 | | } => BluerEvent::RequestResponse {
| |_________________________- matches some of the same values
...
151 | BluerSessionEvent::AgentEvent(e) => BluerEvent::AgentEvent(e),
| -------------------------------- matches some of the same values
152 |
153 | _ => return,
| ^ collectively making this unreachable
= note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default
|
|
Run actions-rs-plus/clippy-check@v2:
cosmic-applet-bluetooth/src/app.rs#L27
warning: unused import: `sync::LazyLock`
--> cosmic-applet-bluetooth/src/app.rs:27:33
|
27 | use std::{collections::HashMap, sync::LazyLock, time::Duration};
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
|
background
wait
wait-all
cancel
Loading