fix(status-area): don't panic when SNI signal streams fail to initialize#1425
Open
BrianHotopp wants to merge 1 commit into
Open
fix(status-area): don't panic when SNI signal streams fail to initialize#1425BrianHotopp wants to merge 1 commit into
BrianHotopp wants to merge 1 commit into
Conversation
5 tasks
BrianHotopp
force-pushed
the
fix-sni-subscription-unwrap-panic
branch
from
99974fd to
66b8e13
Compare
Three receive_*().await.unwrap() calls (receive_new_icon, receive_layout_updated, receive_items_properties_updated) under panic=abort could take down the whole applet on a transient D-Bus error. Replace each with a match that warns and degrades to an empty stream via left_stream()/right_stream(), keeping the happy path intact. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
BrianHotopp
force-pushed
the
fix-sni-subscription-unwrap-panic
branch
from
66b8e13 to
dae6486
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three
receive_*().await.unwrap()calls (receive_new_icon,receive_layout_updated,receive_items_properties_updated) in the status-area SNI subscriptions could abort the whole applet (compiled withpanic = "abort") if a tray item's D-Bus signal subscription failed to set up. This replaces each unwrap with a match that warns and degrades to an empty stream vialeft_stream()/right_stream(), so one misbehaving item no longer takes down every tray icon.Test plan
cargo build -p cosmic-applet-status-area(in-container) — builds clean.