Skip to content

Write SHA-512 sibling in binary mode for cross-platform byte-identical output #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SeanTAllen merged 1 commit into from
Apr 15, 2026
Merged

Write SHA-512 sibling in binary mode for cross-platform byte-identical output #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .ci-scripts/release/github_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,11 @@ def write_sha512_sibling(archive_path):
for chunk in iter(lambda: f.read(1024 * 1024), b''):
h.update(chunk)
sibling_path = archive_path + '.sha512'
with open(sibling_path, 'w') as f:
f.write(h.hexdigest() + '\n')
# Binary mode: keep the digest file byte-identical across platforms.
# Text mode on Windows would rewrite '\n' as '\r\n' and produce Windows
# archives with CRLF-terminated siblings while Linux/macOS produce LF.
with open(sibling_path, 'wb') as f:
f.write((h.hexdigest() + '\n').encode('ascii'))
return sibling_path


Expand Down
Loading