Skip to content

[Exporter] Fix parameter direction and type emission in exportArgument #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p2peek wants to merge 1 commit into
base: fruffy/top4
Choose a base branch
from
Open

[Exporter] Fix parameter direction and type emission in exportArgument #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 56 additions & 15 deletions lib/Utilities/export_to_p4.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4436,26 +4436,67 @@ class P4HirToP4Exporter {
/// ```p4
/// in bit<32> data
/// ```
// mlir::LogicalResult exportArgument(mlir::FunctionOpInterface functionInterface,
// ExtendedFormattedOStream &ss, int index) {
// if (auto argAttrs = functionInterface.getArgAttrsAttr()) {
// if (index < static_cast<int>(argAttrs.size())) {
// if (auto dict =
// mlir::dyn_cast_if_present<mlir::DictionaryAttr>(argAttrs[index])) {
// auto annots =
// mlir::dyn_cast_if_present<mlir::DictionaryAttr>(dict.get("annotations"));
// if (!annots) {
// annots = mlir::dyn_cast_if_present<mlir::DictionaryAttr>(
// dict.get("p4hir.annotations"));
// }
// if (annots) {
// if (failed(exportAnnotations(annots, ss))) {
// return mlir::failure();
// }
// }
// }
// }
// }




mlir::LogicalResult exportArgument(mlir::FunctionOpInterface functionInterface,
ExtendedFormattedOStream &ss, int index) {
if (auto argAttrs = functionInterface.getArgAttrsAttr()) {
if (index < static_cast<int>(argAttrs.size())) {
if (auto dict =
mlir::dyn_cast_if_present<mlir::DictionaryAttr>(argAttrs[index])) {
auto annots =
mlir::dyn_cast_if_present<mlir::DictionaryAttr>(dict.get("annotations"));
if (!annots) {
annots = mlir::dyn_cast_if_present<mlir::DictionaryAttr>(
dict.get("p4hir.annotations"));
}
if (annots) {
if (failed(exportAnnotations(annots, ss))) {
return mlir::failure();
}
ExtendedFormattedOStream &ss, int index) {
// 🔹 Handle annotations
if (auto argAttrs = functionInterface.getArgAttrsAttr()) {
if (index < static_cast<int>(argAttrs.size())) {
if (auto dict =
mlir::dyn_cast_if_present<mlir::DictionaryAttr>(argAttrs[index])) {
auto annots =
mlir::dyn_cast_if_present<mlir::DictionaryAttr>(dict.get("annotations"));
if (!annots) {
annots = mlir::dyn_cast_if_present<mlir::DictionaryAttr>(
dict.get("p4hir.annotations"));
}
if (annots) {
if (failed(exportAnnotations(annots, ss))) {
return mlir::failure();
}
}
}
}
}

ss << "in ";

auto type = functionInterface.getArgumentTypes()[index];
if (failed(exportP4Type(type, ss))) {
return mlir::failure();
}

ss << " arg" << index;

return mlir::success();
}




// Export direction (in, out, inout).
auto directionAttr =
functionInterface.getArgAttr(index, P4HIR::FuncOp::getDirectionAttrName());
Expand Down