[Exporter] Fix parameter direction and type emission in exportArgument#334
Open
p2peek wants to merge 1 commit intop4lang:fruffy/top4from
Open
[Exporter] Fix parameter direction and type emission in exportArgument#334p2peek wants to merge 1 commit intop4lang:fruffy/top4from
p2peek wants to merge 1 commit intop4lang:fruffy/top4from
Conversation
Collaborator
|
Hi @p2peek can you set the base to the exporter branch so we can see the actual diff? |
p2peek
force-pushed
the
clean-fix-parameter
branch
4 times, most recently
from
5680a45 to
b71d4c7
Compare
…ment Signed-off-by: root <root@prakash.localdomain> Signed-off-by: Prakash Kumar <kumarprakash3909@gmail.com>
p2peek
force-pushed
the
clean-fix-parameter
branch
from
b71d4c7 to
aa62978
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes parameter emission in the P4HIR → P4 exporter.
Currently, exportArgument(...) only emits annotations and misses:
This change ensures that parameters are printed as valid P4 syntax, e.g.:
This is a minimal fix toward completing the exporter described in PR #168.
Next steps include: