semver: widen comparator counter to u32 to avoid debug overflow panic#31010
Merged
Claude / Claude Code Review
completed
May 18, 2026 in 21m 48s
Code review found 2 potential issues
Found 3 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/cli/install/semver.test.ts:749-751 |
Test pipes stderr but never reads it |
Annotations
Check warning on line 751 in test/cli/install/semver.test.ts
claude / Claude Code Review
Test pipes stderr but never reads it
nit: `stderr: "pipe"` is set but `proc.stderr` is never read, so if this regression ever recurs the Rust panic message gets silently discarded and CI will only show `stdout=""` / `exitCode=133` with no diagnostic. Consider adding `proc.stderr.text()` to the `Promise.all` and asserting `expect(stderr).toBe("")` (per the spawn-test pattern in test/CLAUDE.md), or just drop `stderr: "pipe"` so failures inherit to the runner output.
Loading