Skip to content

semver: widen comparator counter to u32 to avoid debug overflow panic #31010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 7 commits into from
May 19, 2026
Merged

semver: widen comparator counter to u32 to avoid debug overflow panic #31010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef41651
semver: widen comparator counter to u32 to avoid debug overflow panic
alii May 18, 2026
ef9b2b6
Remove unnecessary inline comments
robobun May 18, 2026
b5e51db
test: surface stderr on subprocess failure
robobun May 18, 2026
90793cd
Restore u32 counter (accidentally reverted in b5e51dbd39)
robobun May 18, 2026
0a802c5
Unblock debug build and give slow debug tests headroom
robobun May 18, 2026
6c0c678
ci: retrigger
robobun May 18, 2026
e21ce99
test: check stderr before stdout so panic backtrace surfaces in the diff
robobun May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/jsc/bindings/wtf-bindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ extern "C" int uv_tty_reset_mode(void)

static void uv__tty_make_raw(struct termios* tio)
{
assert(tio != NULL);
ASSERT(tio != NULL);

#if defined __sun || defined __MVS__
/*
Expand Down
2 changes: 1 addition & 1 deletion src/semver/SemverQuery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ pub fn parse(input: &[u8], sliced: SlicedString) -> Result<Group, AllocError> {
let mut token = Token::default();
let mut prev_token = Token::default();

let mut count: u8 = 0;
let mut count: u32 = 0;
Comment thread
robobun marked this conversation as resolved.
let mut skip_round;
let mut is_or = false;

Expand Down
17 changes: 16 additions & 1 deletion test/cli/install/semver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
// ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
// IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

import { bunEnv, bunExe } from "harness";
import { unsortedPrereleases } from "./semver-fixture.js";
const { satisfies, order } = Bun.semver;

Expand Down Expand Up @@ -226,7 +227,7 @@ describe("Bun.semver.satisfies()", () => {
}
}
Bun.gc(true);
});
}, 30_000);

test("exact versions", () => {
testSatisfiesExact("1.2.3", "1.2.3", true);
Expand Down Expand Up @@ -738,3 +739,17 @@ describe("Bun.semver.satisfies()", () => {
expect(unsortedPrereleases.sort(Bun.semver.order)).toMatchSnapshot();
});
});

test("a version range with >=256 || comparators does not abort", async () => {
const range = Array(300).fill("1.0.0").join(" || ");
await using proc = Bun.spawn({
cmd: [bunExe(), "-e", `process.stdout.write(String(Bun.semver.satisfies("1.0.0", ${JSON.stringify(range)})))`],
env: bunEnv,
stdout: "pipe",
stderr: "pipe",
});
const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]);
if (exitCode !== 0) expect(stderr).toBe("");
expect(stdout).toBe("true");
expect(exitCode).toBe(0);
}, 30_000);
Loading