Implement Loading saved JSON files into the frontend configuration wizard #299#305
Merged
CharlieWells13 merged 17 commits intomainfrom Apr 14, 2026
Merged
Conversation
Collaborator
|
Good start Ahmed, I look forward to seeing the completion of this in the coming weeks! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ahmedbektic
changed the title
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ttps://github.com/oss-slu/DroneWorld into feature/loading-and-saving-mission-configurations
CharlieWells13
requested changes
Apr 13, 2026
Collaborator
CharlieWells13
left a comment
CharlieWells13
left a comment
There was a problem hiding this comment.
Hello, this is a great start, here's what is good:
- saving and loading the presets themselves
- the saved setting page
Big issue:
The presets you have set up are exact copies in name of the names of the mission types on the first page, in both name a description
We will need to have a deeper discussion on how to properly set up these presets and how the program actually functions in class today on how to properly set these up.
Small issue:
Layout is a little too vertical for my liking, not a big deal at all but something small we should fix, i have henry working on it rn
Kept feature branch routeState/alert pattern and merged in clearAllDrones() fix from main. Dropped frontend/.env (deleted in main). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CharlieWells13
approved these changes
Apr 14, 2026
Collaborator
CharlieWells13
left a comment
CharlieWells13
left a comment
There was a problem hiding this comment.
good now, renamed a bit
- Update preset name in HorizontalLinearStepper test to match rename - Only call clearAllDrones when no importedConfig in route state, preventing it from wiping drones loaded via SavedSettings Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Cypress test was looking for old preset name after rename. format:check reverted to format (like main) to unblock merge; prettier formatting cleanup to follow in a separate PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #299
Summary
This PR completes the frontend saved-configuration import flow so users can load an existing simulator configuration into the wizard, edit it, and continue through the normal submission flow.
What changed
/saved-settingssettings.jsonplus matchingtask.json/saved-settingsactions to:Why
How
frontend/src/services/configImport/settings+task)settings.jsonType of Change
Acceptance Criteria Verification (from linked issue)