8379867: C2 VectorAPI: Rename TypeVectMask -> TypePVectMask for clarity

[dev-jonghoonpark]

changes

• Renamed TypeVectMask class to TypePVectMask.
• Renamed accessor methods accordingly:
  • is_vectmask() → is_pvectmask()
  • isa_vectmask() → isa_pvectmask().

Test

• Verified that make images completes without errors.
• Confirmed that Tier1 tests pass successfully.
• Confirmed that hotspot_vector_1 tests and jdk_vector tests pass successfully.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8379867: C2 VectorAPI: Rename TypeVectMask -> TypePVectMask for clarity (Enhancement - P4)

Reviewers

• Emanuel Peter (@eme64 - Reviewer)
• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30812/head:pull/30812
$ git checkout pull/30812

Update a local copy of the PR:
$ git checkout pull/30812
$ git pull https://git.openjdk.org/jdk.git pull/30812/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30812

View PR using the GUI difftool:
$ git pr show -t 30812

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30812.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dev-jonghoonpark! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dev-jonghoonpark This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379867: C2 VectorAPI: Rename TypeVectMask -> TypePVectMask for clarity

Reviewed-by: epeter, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• b221cb6: 8347112: Copy nested directories in doc-files by default
• f5460ce: 8367342: Doclet documentation is incomplete
• fa874fa: 8374629: Type test pattern with array type in switch fails to parse
• ... and 17 more: https://git.openjdk.org/jdk/compare/edff559cef5f21a61de5054cb91f1817d5c23e12...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@eme64, @PaulSandoz) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@dev-jonghoonpark The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 03: Full (c237fe56)
• 02: Full - Incremental (ef86f745)
• 01: Full (ce05b3cb)
• 00: Full (4b47e937)

[eme64]

@dev-jonghoonpark Thanks for taking on this task. I'll run some internal sanity testing now...

[eme64]

Testing passed, change looks good!

[openjdk]

@dev-jonghoonpark this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8379867
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[dev-jonghoonpark]

@eme64

Thank you for the review.
I've resolved the conflicts and merged the changes.

Do we need another reviewer on this?

[PaulSandoz]

Looks good, simple rename, and tests pass. Please merge master into this PR and recheck locally all is good before integrating since it's been a few days.

[dev-jonghoonpark]

@PaulSandoz
Following your advice, I have merged the latest master and confirmed that the local tier1 tests pass without issues.

so I’ll proceed with the integration now.

[dev-jonghoonpark]

/integrate

[openjdk]

@dev-jonghoonpark This pull request has not yet been marked as ready for integration.

[dev-jonghoonpark]

It seems I need a re-review from @eme64 before I can proceed with /integrate.

Could you please take another look?

[eme64]

Changes look good. I don't want to have to run testing again, and I think we could rely on GitHub actions testing. But it seems that is disabled, and only jcheck is running here. Can you please make sure that pre-submit tests are run?

[dev-jonghoonpark]

Thank you for the advice. I wasn't aware of this approach until now.

The pre-submit tests are currently running, and I will share the results with you as soon as they are completed.
https://github.com/dev-jonghoonpark/jdk-forked/actions/runs/25185087543

[dev-jonghoonpark]

@eme64 The pre-submit tests have completed successfully.

[eme64]

Great, thanks for enabling it! Ship it!

[dev-jonghoonpark]

/integrate

[openjdk]

@dev-jonghoonpark
Your change (at version c237fe5) is now ready to be sponsored by a Committer.

[eme64]

/sponsor

[openjdk]

Going to push as commit 3ba94ae.
Since your change was applied there have been 20 commits pushed to the master branch:

• b221cb6: 8347112: Copy nested directories in doc-files by default
• f5460ce: 8367342: Doclet documentation is incomplete
• fa874fa: 8374629: Type test pattern with array type in switch fails to parse
• ... and 17 more: https://git.openjdk.org/jdk/compare/edff559cef5f21a61de5054cb91f1817d5c23e12...master

Your commit was automatically rebased without conflicts.

[openjdk]

@eme64 Pushed as commit 3ba94ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.