Skip to content

8382481: GenShen: Compilation failure using GCC 14 #30805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
earthling-amzn wants to merge 1 commit into from
Closed

8382481: GenShen: Compilation failure using GCC 14 #30805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hotspot/share/gc/shenandoah/shenandoahGenerationalHeap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,13 +800,13 @@ class ShenandoahGenerationalUpdateHeapRefsTask : public WorkerTask {
template<class T>
void update_references_in_remembered_set(uint worker_id, T &cl, const ShenandoahMarkingContext* ctx, bool is_mixed) {

struct ShenandoahRegionChunk assignment;
ShenandoahRegionChunk assignment;
ShenandoahScanRemembered* scanner = _heap->old_generation()->card_scan();

while (!_heap->check_cancelled_gc_and_yield(CONCURRENT) && _work_chunks->next(&assignment)) {
// Keep grabbing next work chunk to process until finished, or asked to yield
ShenandoahHeapRegion* r = assignment._r;
if (r->is_active() && !r->is_cset() && r->is_old()) {
if (r != nullptr && r->is_active() && !r->is_cset() && r->is_old()) {
HeapWord* start_of_range = r->bottom() + assignment._chunk_offset;
HeapWord* end_of_range = r->get_update_watermark();
if (end_of_range > start_of_range + assignment._chunk_size) {
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.inline.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ inline bool ShenandoahRegionChunkIterator::has_next() const {
return _index.load_relaxed() < _total_chunks;
}

inline bool ShenandoahRegionChunkIterator::next(struct ShenandoahRegionChunk *assignment) {
inline bool ShenandoahRegionChunkIterator::next(ShenandoahRegionChunk* assignment) {
if (_index.load_relaxed() >= _total_chunks) {
return false;
}
Expand Down