Skip to content

8382481: GenShen: Compilation failure using GCC 14#30805

Closed
earthling-amzn wants to merge 1 commit intoopenjdk:masterfrom
earthling-amzn:fix-gcc-14-compilation-error
Closed

8382481: GenShen: Compilation failure using GCC 14#30805
earthling-amzn wants to merge 1 commit intoopenjdk:masterfrom
earthling-amzn:fix-gcc-14-compilation-error

Conversation

@earthling-amzn
Copy link
Copy Markdown
Contributor

@earthling-amzn earthling-amzn commented Apr 17, 2026

GCC 14's deeper inlining optimizations interact badly with stringop-overflow here. It falsely detects that the region pointer could be null. Simplest fix is to just add a nullptr check for it. Alternatively, should we consider disabling this warning? The Linux kernel has: https://www.phoronix.com/news/Linux-Drop-GCC--Wstringop-of.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8382481: GenShen: Compilation failure using GCC 14 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30805/head:pull/30805
$ git checkout pull/30805

Update a local copy of the PR:
$ git checkout pull/30805
$ git pull https://git.openjdk.org/jdk.git pull/30805/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30805

View PR using the GUI difftool:
$ git pr show -t 30805

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30805.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 17, 2026

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Apr 17, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 17, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 17, 2026

Webrevs

@pengxiaolong
Copy link
Copy Markdown

We also noticed this error in Jenkins pipeline, but with GCC13.

@earthling-amzn
Copy link
Copy Markdown
Contributor Author

earthling-amzn commented Apr 21, 2026

Closing without integrating in favor of #30784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants