csr_regfile: Fix SBE/UBE when S/U-mode disabled#3302
Open
pointerliu wants to merge 1 commit into
Open
Conversation
According to RISC-V privileged spec, SBE must be read-only 0 when S-mode is not supported, and UBE must be read-only 0 when U-mode is not supported. Previously MBE was mirrored to SBE and UBE unconditionally, which could set them to 1 even when the corresponding privilege mode was absent. Now the mirroring is conditional on CVA6Cfg.RVS and CVA6Cfg.RVU respectively, hardwiring to 0 when the mode is not supported.
Contributor
|
Hello @pointerliu |
Author
|
Hi @JeanRochCoulon, I've signed the ECA using the same email as github. Please let me know if anything else is needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to RISC-V privileged spec, SBE must be read-only 0 when S-mode is not supported, and UBE must be read-only 0 when U-mode is not supported. Previously MBE was mirrored to SBE and UBE unconditionally, which could set them to 1 even when the corresponding privilege mode was absent.
Now the mirroring is conditional on CVA6Cfg.RVS and CVA6Cfg.RVU respectively, hardwiring to 0 when the mode is not supported.
Fix #3301