Fix aes32esi bug#3243
Open
antonangeloff wants to merge 3 commits into
Open
Conversation
cainria
reviewed
Mar 23, 2026
cainria
suggested changes
Mar 23, 2026
antonangeloff
force-pushed
the
fix-aes32esi-bug
branch
from
becb61e to
f23ad6b
Compare
cainria
approved these changes
Mar 23, 2026
Contributor
|
👋 Hi there! This pull request seems inactive. Need more help or have updates? Feel free to let us know. If there are no updates within the next few days, we'll go ahead and close this PR. 😊 |
github-actions
Bot
added
the
Status:Stale
Author
|
@cainria @JeanRochCoulon, please let me know if anything else is needed |
github-actions
Bot
removed
the
Status:Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR attempts to fix this aes32esi bug - which seems to be caused by
orig_instr_o(raw instruction word) being assigned only ifCVA6Cfg.CvxifEn || CVA6Cfg.RVFare enabled, though it's used downstream by theZKNfeatures as well (not onlyaes32esi, but also other instructions). I.e. the bug is manifested ifZKNis enabled, butCvxifEnandRVFare not; otherwise the AES implementation seems to work correctly.Also because
ZKNseems to depend onRVBbeing enabled as well, the PR also auto-enablesRVBwhenZKNis present (if it make sense a warning can be added in case it gets auto-enabled).The files attached in the issue can be used to test the fix.