Skip to content

MIRV warheads now spawn well in impassible terrain #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TKTK123456 wants to merge 4 commits into
base: main
Choose a base branch
from
+21 −7
Open

MIRV warheads now spawn well in impassible terrain #4756

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
866851b
Fixed da bug
TKTK123456 Jul 28, 2026
5123d5a
Added test because code rabbit wants me too
TKTK123456 Jul 28, 2026
778b977
Formatted
TKTK123456 Jul 28, 2026
c184c74
Fixed error in test
TKTK123456 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/core/execution/NukeExecution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,15 +191,17 @@ export class NukeExecution implements Execution {
// The launch tile can be overridden by the caller (e.g. MIRV warheads
// launch from the MIRV separation point, not a silo).
this.src ??= spawn;
// Nuke trajectories cannot pass over impassable terrain, just as they
// Nuke trajectories cannot pass over impassable terrain unless they are MIRV warheads, just as they
// cannot exceed the map border. Check the full parabola path before
// launching; if any tile is impassable, abort the launch.
const path = this.pathFinder.findPath(this.src, this.dst) ?? [];
for (const tile of path) {
if (this.mg.isImpassable(tile)) {
console.warn(`nuke trajectory crosses impassable terrain`);
this.active = false;
return;
if (this.nukeType !== UnitType.MIRVWarhead) {
const path = this.pathFinder.findPath(this.src, this.dst) ?? [];
for (const tile of path) {
if (this.mg.isImpassable(tile)) {
console.warn(`nuke trajectory crosses impassable terrain`);
this.active = false;
return;
}
Comment thread
TKTK123456 marked this conversation as resolved.
}
}
this.nuke = this.player.buildUnit(this.nukeType, this.src, {
Expand Down
Loading