Skip to content

RT-1.1 #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cprabha wants to merge 3 commits into
base: main
Choose a base branch
from
Open

RT-1.1 #5809

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6790a3
fixed issue with ncptx
cprabha Jul 30, 2026
a7de67c
Update base_bgp_session_parameters_test.go
cprabha Jul 30, 2026
eea27fb
Resolving
cprabha Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions feature/bgp/otg_tests/base_bgp_session_parameters/base_bgp_session_parameters_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package base_bgp_session_parameters_test

import (
"slices"
"testing"
"time"

Expand Down Expand Up @@ -49,6 +50,7 @@ var (
IPv4: "192.0.2.2",
IPv4Len: 30,
}
kneDeviceModelList = []string{"ncptx"}
Comment thread
cprabha marked this conversation as resolved.
)

// Constants.
Expand Down Expand Up @@ -414,7 +416,8 @@ func TestPassword(t *testing.T) {

// If the DUT will not fail a BGP session when the BGP MD5 key configuration changes,
// change the key from the ATE side to time out the session.
if deviations.BGPMD5RequiresReset(dut) {
if slices.Contains(kneDeviceModelList, dut.Model()) || deviations.BGPMD5RequiresReset(dut) {
t.Logf("DUT Model: %s", dut.Model())
Comment thread
cprabha marked this conversation as resolved.
port1 := ate.Port(t, "port1")
topo := gosnappi.NewConfig()

Expand All @@ -433,7 +436,6 @@ func TestPassword(t *testing.T) {
peerBGP.SetPeerAddress(ip.Gateway()).SetAsNumber(ateAS).SetAsType(gosnappi.BgpV4PeerAsType.EBGP)
ate.OTG().PushConfig(t, topo)
ate.OTG().StartProtocols(t)

}
t.Log("Wait till hold time expires: BGP should not be in ESTABLISHED state when passwords do not match.")
_, ok := gnmi.Watch(t, dut, nbrPath.SessionState().State(), (dutHoldTime+10)*time.Second, func(val *ygnmi.Value[oc.E_Bgp_Neighbor_SessionState]) bool {
Expand All @@ -447,7 +449,7 @@ func TestPassword(t *testing.T) {

t.Log("Revert md5 auth password on DUT to match with ATE.")
gnmi.Replace(t, dut, dutConfPath.Bgp().Neighbor(ateAttrs.IPv4).AuthPassword().Config(), authPassword)
if deviations.BGPMD5RequiresReset(dut) {
if slices.Contains(kneDeviceModelList, dut.Model()) || deviations.BGPMD5RequiresReset(dut) {
topo := configureATE(t, &bgpTestParams{localAS: ateAS, peerIP: dutAttrs.IPv4}, connExternal, md5Auth)
t.Log("Pushing config to ATE and starting protocols...")
ate.OTG().PushConfig(t, topo)
Expand Down
Loading