RT-1.1

[cprabha]

Hi,

On ncptx environment it needs reset on otg contaner side hence updated script to run on ncptx.

[OpenConfigBot]

Pull Request Functional Test Report for #5809 / eea27fb

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.1: Base BGP Session Parameters
Cisco 8000E		RT-1.1: Base BGP Session Parameters
Cisco XRd		RT-1.1: Base BGP Session Parameters
Juniper ncPTX		RT-1.1: Base BGP Session Parameters
Nokia SR Linux		RT-1.1: Base BGP Session Parameters
Openconfig Lemming		RT-1.1: Base BGP Session Parameters

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.1: Base BGP Session Parameters
Cisco 8808		RT-1.1: Base BGP Session Parameters
Juniper PTX10008		RT-1.1: Base BGP Session Parameters
Nokia 7250 IXR-10e		RT-1.1: Base BGP Session Parameters

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the BGP session parameter tests to ensure proper functionality within the ncptx environment. By introducing a device model tracking mechanism, the test suite now correctly identifies when a BGP session reset is required for specific hardware, improving reliability during MD5 key configuration changes.

Highlights

• Device Model Support: Added the 'ncptx' device model to a new configuration list to explicitly manage its requirements.
• Test Logic Enhancement: Updated the BGP password test to trigger a session reset when the DUT model is identified as 'ncptx'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a hardcoded model check for 'ncptx' in TestPassword to determine if a BGP MD5 reset is required. The reviewer feedback correctly points out that this violates the repository's Deviation Guidelines, which require platform-specific workarounds to be handled via the deviations framework rather than hardcoded in test files. Additionally, the change introduces a compilation error because the 'slices' package is used but not imported. The reviewer recommends reverting the hardcoded check and instead enabling the existing 'bgp_md5_requires_reset' deviation for the 'ncptx' platform in the metadata configuration.