Skip to content

fix(react): honor default value for missing feature flags #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jyatin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(react): honor default value for missing feature flags #1451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/declarative/FeatureFlag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export function FeatureFlag<T extends FlagValue = FlagValue>({
});

// If the flag evaluation failed, we render the fallback
if (details.reason === 'ERROR') {
if (details.reason === 'ERROR' && details.details?.errorCode !== 'FLAG_NOT_FOUND') {
const fallbackNode: React.ReactNode =
typeof fallback === 'function' ? fallback(details.details as EvaluationDetails<T>) : fallback;
return <>{fallbackNode}</>;
Expand Down
11 changes: 11 additions & 0 deletions packages/react/test/declarative.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,17 @@ describe('Feature Component', () => {

expect(screen.queryByText(childText)).toBeInTheDocument();
});
it('should render children when flag is missing and defaultValue is true', () => {
render(
<OpenFeatureProvider domain={EVALUATION}>
<FeatureFlag flagKey={MISSING_FLAG_KEY} defaultValue={true}>
<ChildComponent />
</FeatureFlag>
</OpenFeatureProvider>,
);

expect(screen.queryByText(childText)).toBeInTheDocument();
});

it('should not show a non-boolean feature flag without match', () => {
render(
Expand Down
Loading