fix(react): honor default value for missing feature flags - #1451
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthrough
ChangesFeatureFlag fallback behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change makes missing feature flags honor their provided default values, with no actionable merge-blocking risk remaining after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi, the implementation and tests are complete, and the automated checks are passing. Could a code owner from open-feature/maintainers or open-feature/sdk-javascript-maintainers please review this PR when available? Thanks! |
|
Hi! Just following up on PR #1451 when you get a chance. The implementation and tests are complete, and all required checks are passing. It’s currently just waiting on a code-owner review. Thanks! |
Signed-off-by: Jyatin Singh <singhjyatin@gmail.com>
bee99ae to
4ebb05a
Compare
Description
Fixes an issue where
FeatureFlagtreated a missing flag as an error and rendered the fallback instead of using the provideddefaultValue.When the evaluation reason is
ERRORwithFLAG_NOT_FOUND, the component now continues through the normal matching logic so boolean flags can correctly use their default value.Testing
git diff --checkpassedFixes #1447