Add LGBMRanker support (with unit tests)#754
Closed
anttoniksan wants to merge 2 commits into
Closed
Conversation
Signed-off-by: anttoniksan <anttoni.koivu@sanoma.com>
anttoniksan
force-pushed
the
add-lightgbm-ranker
branch
from
c23180f to
03de9d3
Compare
xadupre
approved these changes
Jan 30, 2026
anttoniksan
force-pushed
the
add-lightgbm-ranker
branch
6 times, most recently
from
5a6b31f to
e0f61b7
Compare
Signed-off-by: anttoniksan <anttoni.koivu@sanoma.com>
anttoniksan
force-pushed
the
add-lightgbm-ranker
branch
from
e0f61b7 to
67eac6d
Compare
|
Collaborator
|
reaplace by #755. |
xadupre
added a commit
that referenced
this pull request
Jan 30, 2026
Complete PR #754, fix merging conflicts and remaining unittests. --------- Signed-off-by: anttoniksan <anttoni.koivu@sanoma.com> Signed-off-by: Xavier Dupré <xadupre@microsoft.com> Co-authored-by: anttoniksan <anttoni.koivu@sanoma.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As both #730 and #580 pull requests were never merged, here is one that should implement the desired functionality alongside unit tests.