Support LGBMRanker conversion (updated)#730
Closed
J-tt wants to merge 3 commits into
Closed
Conversation
J-tt
force-pushed
the
add-lightgbm-ranker-transform
branch
from
3a5a9ca to
33936f0
Compare
Signed-off-by: Jett Jackson <me@jett.dev>
Signed-off-by: Jett Jackson <me@jett.dev>
Signed-off-by: Jett Jackson <me@jett.dev>
J-tt
force-pushed
the
add-lightgbm-ranker-transform
branch
from
33936f0 to
8001777
Compare
Collaborator
|
Could you add a unit test? I don't mind completed the pull but it would help to have a unit test checking your changes are working. |
|
Author
|
Closing this in favour of #754 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is an updated version of #580 with the merge conflicts resolved, as it seems that PR is inactive now.
I'll try and keep the fork up to date