[ENG-613] Added expiry date to supply delivery table by Jacobjeevan · Pull Request #16579 · ohcnetwork/care_fe

Jacobjeevan · 2026-07-17T05:58:12Z

Changes

Added expiry date to supply delivery table

Tests skipped — trivial change.

Summary by CodeRabbit

New Features
- Added an Expiry column to the Supply Delivery table.
- Each delivery row now shows the relevant expiry date formatted as dd/MM/yyyy.
- When an expiry date isn’t available, the table displays “–” instead.

github-actions · 2026-07-17T05:58:25Z

⚠️ Merge Checklist Incomplete

Thank you for your contribution! To help us review your PR efficiently, please complete the merge checklist in your PR description.

Your PR will be reviewed once you have marked the appropriate checklist items.

To update the checklist:

Change - [ ] to - [x] for completed items
Only check items that are relevant to your PR
Leave items unchecked if they don't apply

The checklist helps ensure code quality, testing coverage, and documentation are properly addressed.

coderabbitai · 2026-07-17T05:58:51Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e7001c13-7003-4d11-bf16-e592c0fde1cb

📥 Commits

Reviewing files that changed from the base of the PR and between f339559 and 703e087.

📒 Files selected for processing (1)

src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx

Walkthrough

Changes

Supply delivery expiry display

Layer / File(s)	Summary
Expiry column rendering `src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx`	Adds an expiry header and displays internal or non-internal delivery expiration dates as `dd/MM/yyyy`, falling back to `"-"` when absent.

Possibly related PRs

ohcnetwork/care_fe#16564: Also adds an expiry column with formatted expiration dates and a fallback.
ohcnetwork/care_fe#16565: Also derives and formats delivery expiration dates in SupplyDeliveryTable.tsx.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description omits required template sections, including Proposed Changes details, issue reference, tagging, and the merge checklist.	Fill in the Proposed Changes section with Fixes `#issue_number` and bullets, add the reviewer tagging, and complete the full Merge Checklist.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is specific, concise, and matches the main change: adding expiry dates to the supply delivery table.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch supply-delivery-expiry-date

_{Comment @coderabbitai help to get the list of available commands.}

cloudflare-workers-and-pages · 2026-07-17T05:59:32Z

Deploying care-preview with Cloudflare Pages

Latest commit:	`fc52de5`
Status:	✅ Deploy successful!
Preview URL:	https://eabcbd3b.care-preview-a7w.pages.dev
Branch Preview URL:	https://supply-delivery-expiry-date.care-preview-a7w.pages.dev

View logs

greptile-apps · 2026-07-17T06:00:17Z

Greptile Summary

This PR adds an Expiry column to the SupplyDeliveryTable component, displaying the product's expiration date formatted as dd/MM/yyyy (or "-" when absent). The translation key "expiry" already exists in all locale files, and the column position is correctly aligned between the header and body rows.

Expiry is sourced from supplied_inventory_item.product.expiration_date first, falling back to supplied_item.expiration_date, which mirrors how other fields handle the internal vs. external delivery distinction.
parseISO from date-fns is used for date parsing, which is the safer approach compared to new Date() used for created_date elsewhere in the same file.

Confidence Score: 5/5

Safe to merge — the change is a straightforward column addition with no logic side-effects and no impact on existing columns or data mutations.

The change only adds a read-only display column. The translation key exists, date parsing uses the correct parseISO helper, column alignment between header and body is correct, and both data sources for the expiry value are properly guarded with optional chaining.

No files require special attention.

Important Files Changed

Filename	Overview
src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx	Adds an "Expiry" column to the supply delivery table, reading from `supplied_inventory_item.product.expiration_date` with a fallback to `supplied_item.expiration_date`, formatted via `parseISO` and date-fns — column placement is consistent between header and body rows.

_{Reviews (2): Last reviewed commit: "care-loop: address review feedback (roun..." | Re-trigger Greptile}

Copilot

Pull request overview

Adds an Expiry column to the facility inventory Supply Delivery table so users can see batch expiry dates alongside delivered items.

Changes:

Added an “Expiry” table header to the Supply Delivery table.
Rendered expiry date per row (preferring supplied_inventory_item.product.expiration_date, falling back to supplied_item.expiration_date) and formatted it as dd/MM/yyyy with - when missing.

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx`:
- Around line 290-299: Update the expiry rendering in SupplyDeliveryTable to
parse the serialized date-only expiration_date with date-only-safe parsing such
as parseISO before formatDate, avoiding timezone-based day shifts. Add a
regression test covering a date-only expiry value and verify the displayed date
remains unchanged.
- Around line 290-299: Update the expiry selection in the TableCell rendering to
use the same internal-branch condition as the product-name logic, choosing the
inventory product expiration for internal deliveries and the supplied-item
expiration for external deliveries. Preserve the existing date formatting and
"-" fallback.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f43e77b2-63b8-4657-8505-be162c7e4c87

📥 Commits

Reviewing files that changed from the base of the PR and between 83d48a0 and f339559.

📒 Files selected for processing (1)

src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx

github-actions · 2026-07-17T06:11:13Z

🎭 Playwright Test Results

Status: ❌ Failed
Test Shards: 3

Metric	Count
Total Tests	337
✅ Passed	334
❌ Failed	2
⏭️ Skipped	1

📊 Detailed results are available in the playwright-final-report artifact.

_{Run: #10556}

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

github-actions

Fine. 13 lines changed, one column added, parseISO correctly used for ISO string dates, fallback to "-" is appropriate. The logic is sound.

One gripe (see inline): ditch the IIFE, extract expiry to a plain const before the return. That's literally all I ask. Is that too much? Apparently.

Also — the PR description says "tests skipped — trivial change." It is trivial, so fine. At least someone is honest.

Generated by Grumpy PR Reviewer for issue #16579 · 20.8 AIC · ⌖ 6 AIC · ⊞ 6.3K

github-actions · 2026-07-31T16:47:22Z

+                return expiry
+                  ? formatDate(parseISO(expiry), "dd/MM/yyyy")
+                  : "-";
+              })()}


An IIFE inside JSX? Really? In 2026? Just extract expiry to a const before the return statement — you know, like a normal human. The entire IIFE exists to derive one variable; that's what const is for.

const expiry = delivery.supplied_inventory_item?.product?.expiration_date || delivery.supplied_item?.expiration_date; // ... <TableCell> {expiry ? formatDate(parseISO(expiry), "dd/MM/yyyy") : "-"} </TableCell>

Cleaner, readable, no gymnastics required.

Add expiry date to supply delivery table

f339559

Jacobjeevan requested review from a team and Copilot July 17, 2026 05:58

Jacobjeevan added the agentic-workflows label Jul 17, 2026

ohc-project-manager Bot assigned Jacobjeevan Jul 17, 2026

ohc-project-manager Bot added needs testing needs review labels Jul 17, 2026

Copilot started reviewing on behalf of Jacobjeevan July 17, 2026 05:58 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

coderabbitai Bot reviewed Jul 17, 2026

View reviewed changes

Comment thread src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx

care-loop: address review feedback (round 2)

703e087

Copilot AI review requested due to automatic review settings July 17, 2026 06:13

Copilot started reviewing on behalf of Jacobjeevan July 17, 2026 06:14 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Jul 17, 2026

[ENG-111] Clicking on an inventory item should display all supply deliveries #16533

Open

8 tasks

navaspavil approved these changes Jul 17, 2026

View reviewed changes

nihal467 added Tested and removed needs testing labels Jul 29, 2026

nihal467 approved these changes Jul 29, 2026

View reviewed changes

Merge branch 'develop' into supply-delivery-expiry-date

089ff1b

Copilot AI review requested due to automatic review settings July 31, 2026 14:20

Copilot started reviewing on behalf of amjithtitus09 July 31, 2026 14:21 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

amjithtitus09 mentioned this pull request Jul 31, 2026

Fix grumpy-reviewer checkout (PR-branch fetch fails: not a git repository) #16617

Merged

Merge branch 'develop' into supply-delivery-expiry-date

fc52de5

Copilot AI review requested due to automatic review settings July 31, 2026 16:24

Copilot started reviewing on behalf of amjithtitus09 July 31, 2026 16:25 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

github-actions Bot reviewed Jul 31, 2026

View reviewed changes

Uh oh!

Conversation

Jacobjeevan commented Jul 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Jul 17, 2026

⚠️ Merge Checklist Incomplete

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

cloudflare-workers-and-pages Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying care-preview with Cloudflare Pages

Uh oh!

greptile-apps Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Jacobjeevan commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Jul 17, 2026 •

edited

Loading

greptile-apps Bot commented Jul 17, 2026 •

edited

Loading

github-actions Bot commented Jul 17, 2026 •

edited

Loading