[ENG-111] Clicking on an inventory item should display all supply deliveries by navaspavil · Pull Request #16533 · ohcnetwork/care_fe

navaspavil · 2026-07-09T07:51:27Z

Proposed Changes

Allow users to view all deliveries for a product from inventory list page.

New Feature: Product Deliveries Drawer

Added a drawer to the inventory list (InventoryList.tsx) that displays all deliveries for a selected product. Users can open this drawer by clicking on a product name in the inventory table.

UI/UX Improvements

Improved button styling in ResourceDefinitionCategoryPicker.tsx for better appearance and usability, including conditional border radius and height adjustments.

ENG-111

Tagging: @ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate the bug or test the new feature.
Update product documentation.
Ensure that UI text is placed in I18n files.
Prepare a screenshot or demo video for the changelog entry and attach it to the issue.
Request peer reviews.
Complete QA on mobile devices.
Complete QA on desktop devices.
Add or update Playwright tests for related changes

Summary by CodeRabbit

New Features
- Added an “All Deliveries” drawer in inventory with product filtering, pagination, and an empty state.
- Enhanced delivery tables with optional origin/destination columns.
- Added the “View product details” label and improved delivery-to-product interactions.
Bug Fixes
- Refined picker and drawer controls (clear-button styling/spacing and button behavior).
- Prevented unintended drawer opening when using the product details link.
Tests
- Extended Playwright coverage for all deliveries drawer states, including pagination.

coderabbitai · 2026-07-09T07:51:40Z

Walkthrough

Changes

The PR adds a product-filtered, paginated “All Deliveries” drawer to inventory summaries, extends delivery data and table rendering, adds Playwright coverage, updates localization, and adjusts category-picker button behavior and styling.

Inventory deliveries

Layer / File(s)	Summary
Delivery data contracts and table rendering `src/types/inventory/...`, `src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx`	Request-order and supply-delivery types expose patient and order data; delivery tables support locations, serial offsets, and updated product selection.
Delivery query and result rendering `src/pages/Facility/services/inventory/InventoryList.tsx`	Adds filtered paginated delivery queries with loading, populated, pagination, and empty-state rendering.
Inventory row and drawer wiring `src/pages/Facility/services/inventory/InventoryList.tsx`, `public/locale/en.json`	Product knowledge buttons open the controlled deliveries drawer while the product-details link remains separate and localized.
All deliveries Playwright coverage `tests/facility/services/locations/inventory/allDeliveries.spec.ts`	Authenticated tests cover populated results, empty results, and page-two requests using offset 10.

Category picker controls

Layer / File(s)	Summary
Trigger and clear button styling `src/components/Common/ResourceDefinitionCategoryPicker.tsx`	Mobile and desktop triggers conditionally remove right rounding, while clear buttons explicitly use button type and updated border, shadow, margin, and height classes.

Possibly related PRs

ohcnetwork/care_fe#16564: Both changes modify delivery table columns and row rendering in SupplyDeliveryTable.tsx.
ohcnetwork/care_fe#16579: Both changes modify per-delivery rendering in SupplyDeliveryTable.tsx.

Suggested labels: needs review, needs testing

Suggested reviewers: copilot, bodhish, jacobjeevan

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: opening an inventory item's deliveries drawer.
Description check	✅ Passed	The description covers the main changes, tagging, screenshot, and most checklist items, though the issue link format is not exact.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ENG-111-clicking-on-an-inventory-item-should-display-all-supply-deliveries

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-09T07:51:46Z

⚠️ Merge Checklist Incomplete

Thank you for your contribution! To help us review your PR efficiently, please complete the merge checklist in your PR description.

Your PR will be reviewed once you have marked the appropriate checklist items.

To update the checklist:

Change - [ ] to - [x] for completed items
Only check items that are relevant to your PR
Leave items unchecked if they don't apply

The checklist helps ensure code quality, testing coverage, and documentation are properly addressed.

github-actions · 2026-07-09T07:51:47Z

⚠️ Merge Checklist Incomplete

Thank you for your contribution! To help us review your PR efficiently, please complete the merge checklist in your PR description.

Your PR will be reviewed once you have marked the appropriate checklist items.

To update the checklist:

Change - [ ] to - [x] for completed items
Only check items that are relevant to your PR
Leave items unchecked if they don't apply

The checklist helps ensure code quality, testing coverage, and documentation are properly addressed.

…nventory item is clicked

cloudflare-workers-and-pages · 2026-07-09T07:53:35Z

Deploying care-preview with Cloudflare Pages

Latest commit:	`f3c02d0`
Status:	✅ Deploy successful!
Preview URL:	https://024fe5dc.care-preview-a7w.pages.dev
Branch Preview URL:	https://eng-111-clicking-on-an-inven.care-preview-a7w.pages.dev

View logs

Copilot

Pull request overview

Adds a new “Product Deliveries” drawer to the facility inventory list so users can click an inventory item and view its related supply deliveries, and includes small UI refinements to the category picker’s clear-button styling.

Changes:

Add a deliveries drawer to InventoryList and open it by clicking a product name in the inventory table.
Fetch and render supply deliveries in the drawer using SupplyDeliveryTable (with an empty state when none exist).
Refine ResourceDefinitionCategoryPicker button border-radius/height behavior when the clear button is present.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
`src/pages/Facility/services/inventory/InventoryList.tsx`	Adds clickable product rows that open a drawer and show supply deliveries for the selected product.
`src/components/Common/ResourceDefinitionCategoryPicker.tsx`	Adjusts button rounding and clear-button styling for improved visual alignment.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

github-actions · 2026-07-09T08:12:12Z

🎭 Playwright Test Results

Status: ✅ Passed
Test Shards: 3

Metric	Count
Total Tests	337
✅ Passed	336
❌ Failed	0
⏭️ Skipped	1

📊 Detailed results are available in the playwright-final-report artifact.

_{Run: #10435}

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

…state management

…efinitionCategoryPicker

…finitionCategoryPicker for mobile

…ility

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

nihal467

https://eng-111-clicking-on-an-inven.care-preview-a7w.pages.dev/facility/f0dbe5f5-58f1-47ed-9133-d34610cc2806/locations/829ff4cb-564f-4f34-93dd-59e6448985b5/inventory/summary

The item count is currently being reset on each page. We need to ensure that the count persists across pages.

…yDeliveryTable

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

…clicking-on-an-inventory-item-should-display-all-supply-deliveries

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx (1)
302-314: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Localize the missing-value placeholders.

The new "-" fallbacks for origin and destination are user-visible literals. Use the existing i18next key for the repository’s missing-value placeholder instead.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx` around lines
302 - 314, Replace the literal "-" fallbacks in the origin and destination cells
of SupplyDeliveryTable with the existing i18next key used for the repository’s
localized missing-value placeholder, preserving the current value precedence and
showLocations condition.
Source: Coding guidelines
src/pages/Facility/services/inventory/InventoryList.tsx (1)
74-121: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Do not treat failed delivery requests as empty results.

When the query errors, deliveries is undefined and this branch renders the “no deliveries found” state. Handle isError with the project’s standard error/retry UI, reserving the empty state for successful responses with zero results.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/pages/Facility/services/inventory/InventoryList.tsx` around lines 74 -
121, The delivery query rendering in InventoryList must distinguish request
failures from successful empty responses. Capture isError (and the
project-standard retry mechanism if required) from useQuery, render the standard
error/retry UI before the deliveries empty-state condition, and reserve
EmptyState for successful responses with zero results.
Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/pages/Facility/services/inventory/InventoryList.tsx`:
- Around line 74-121: The delivery query rendering in InventoryList must
distinguish request failures from successful empty responses. Capture isError
(and the project-standard retry mechanism if required) from useQuery, render the
standard error/retry UI before the deliveries empty-state condition, and reserve
EmptyState for successful responses with zero results.

In `@src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx`:
- Around line 302-314: Replace the literal "-" fallbacks in the origin and
destination cells of SupplyDeliveryTable with the existing i18next key used for
the repository’s localized missing-value placeholder, preserving the current
value precedence and showLocations condition.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 49e12de0-35d5-48d2-9471-574f98b055a6

📥 Commits

Reviewing files that changed from the base of the PR and between f762adc and 079cc54.

📒 Files selected for processing (2)

src/pages/Facility/services/inventory/InventoryList.tsx
src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

…clicking-on-an-inventory-item-should-display-all-supply-deliveries

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

navaspavil self-assigned this Jul 9, 2026

Copilot AI review requested due to automatic review settings July 9, 2026 07:51

ohc-project-manager Bot added the Work in Progress label Jul 9, 2026

Copilot started reviewing on behalf of navaspavil July 9, 2026 07:51 View session

navaspavil added 2 commits July 9, 2026 13:22

fix: Overlapping buttons

e5182d5

feat: implement drawer for displaying all supply deliveries when an i…

db46f8c

…nventory item is clicked

navaspavil force-pushed the ENG-111-clicking-on-an-inventory-item-should-display-all-supply-deliveries branch from e15ef0c to db46f8c Compare July 9, 2026 07:52

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 9, 2026 07:54

Copilot started reviewing on behalf of navaspavil July 9, 2026 07:55 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Remove filter and update button

b1084ff

Copilot AI review requested due to automatic review settings July 9, 2026 10:56

Copilot started reviewing on behalf of navaspavil July 9, 2026 10:56 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread src/pages/Facility/services/inventory/InventoryList.tsx

Comment thread src/pages/Facility/services/inventory/InventoryList.tsx

Comment thread src/pages/Facility/services/inventory/InventoryList.tsx

Comment thread src/components/Common/ResourceDefinitionCategoryPicker.tsx

navaspavil added 4 commits July 9, 2026 17:01

fix: update query key for supply deliveries and simplify drawer open …

58197a9

…state management

fix: add button type attribute to clear selection button in ResourceD…

9bda067

…efinitionCategoryPicker

fix: adjust button styling and clear selection behavior in ResourceDe…

641f3c0

…finitionCategoryPicker for mobile

feat: add accessibility label for product details link in InventoryList

628a6a8

Copilot AI review requested due to automatic review settings July 9, 2026 12:09

Copilot started reviewing on behalf of navaspavil July 9, 2026 12:10 View session

navaspavil marked this pull request as ready for review July 9, 2026 12:12

navaspavil requested review from a team July 9, 2026 12:12

fix: add button type to ResourceDefinitionCategoryPicker for accessib…

f762adc

…ility

Copilot AI review requested due to automatic review settings July 14, 2026 12:41

Copilot started reviewing on behalf of navaspavil July 14, 2026 12:41 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread src/types/inventory/supplyDelivery/supplyDelivery.ts

Comment thread src/types/inventory/requestOrder/requestOrder.ts

Comment thread src/pages/Facility/services/inventory/InventoryList.tsx

coderabbitai Bot mentioned this pull request Jul 17, 2026

[ENG-613] Added expiry date to supply delivery table #16579

Open

nihal467 requested changes Jul 17, 2026

View reviewed changes

ohc-project-manager Bot added Changes Required and removed needs review needs testing labels Jul 17, 2026

feat: update delivery filtering and add serial number offset to Suppl…

5af00b3

…yDeliveryTable

Copilot AI review requested due to automatic review settings July 17, 2026 10:28

Copilot started reviewing on behalf of navaspavil July 17, 2026 10:28 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread src/pages/Facility/services/inventory/SupplyDeliveryTable.tsx

Merge branch 'develop' of github.com:ohcnetwork/care_fe into ENG-111-…

079cc54

…clicking-on-an-inventory-item-should-display-all-supply-deliveries

Copilot AI review requested due to automatic review settings July 17, 2026 10:36

navaspavil force-pushed the ENG-111-clicking-on-an-inventory-item-should-display-all-supply-deliveries branch from 993e326 to 079cc54 Compare July 17, 2026 10:36

Copilot started reviewing on behalf of navaspavil July 17, 2026 10:36 View session

coderabbitai Bot reviewed Jul 17, 2026

View reviewed changes

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread src/pages/Facility/services/inventory/InventoryList.tsx

navaspavil requested a review from nihal467 July 17, 2026 10:41

ohc-project-manager Bot added needs testing needs review and removed Changes Required labels Jul 17, 2026

Merge branch 'develop' of github.com:ohcnetwork/care_fe into ENG-111-…

f3c02d0

…clicking-on-an-inventory-item-should-display-all-supply-deliveries

Copilot AI review requested due to automatic review settings July 27, 2026 07:48

Copilot started reviewing on behalf of navaspavil July 27, 2026 07:49 View session

Copilot AI reviewed Jul 27, 2026

View reviewed changes

nihal467 added Tested and removed needs testing labels Jul 31, 2026

nihal467 approved these changes Jul 31, 2026

View reviewed changes

Uh oh!

Conversation

navaspavil commented Jul 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

New Feature: Product Deliveries Drawer

UI/UX Improvements

Merge Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jul 9, 2026

⚠️ Merge Checklist Incomplete

Uh oh!

github-actions Bot commented Jul 9, 2026

⚠️ Merge Checklist Incomplete

Uh oh!

cloudflare-workers-and-pages Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying care-preview with Cloudflare Pages

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nihal467 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

navaspavil commented Jul 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading