Skip to content

fix: remove unnecessary padding from dosage highlight #16574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amjithtitus09 wants to merge 1 commit into from
Closed

fix: remove unnecessary padding from dosage highlight #16574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Medicine/FormattedDosage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function FormattedDosage({
return (
<span
className={cn(
"rounded bg-yellow-100 px-1.5 py-0.5 font-semibold text-yellow-900",
"rounded bg-yellow-100 font-semibold text-yellow-900",

@greptile-apps greptile-apps Bot Jul 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 With px-1.5 py-0.5 removed, there is no background extending beyond the text, so the rounded class has no visible effect. If the intent is a flat inline highlight with no padding, rounded can be dropped; if some padding is still desired (e.g., just horizontal), the padding values can be adjusted rather than fully removed.

Suggested change
"rounded bg-yellow-100 font-semibold text-yellow-900",
"bg-yellow-100 font-semibold text-yellow-900",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

className,
)}
>
Expand Down
Loading