fix: remove unnecessary padding from dosage highlight - #16574
fix: remove unnecessary padding from dosage highlight#16574amjithtitus09 wants to merge 1 commit into
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughChangesDosage highlight styling
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Removes extra internal spacing from the highlighted (non-unit) dosage rendering in the medicine dosage formatter, so the highlight styling doesn’t add unintended padding around the dosage text.
Changes:
- Removed
px-1.5 py-0.5padding from the highlighted dosage<span>styling inFormattedDosage.
Deploying care-preview with
|
| Latest commit: |
d75058c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://54307045.care-preview-a7w.pages.dev |
| Branch Preview URL: | https://fix-minor-padding.care-preview-a7w.pages.dev |
Greptile SummaryRemoves the horizontal and vertical padding (
Confidence Score: 4/5Safe to merge — the change is a single Tailwind class removal with no logic impact. The only modified file is a presentational component. Removing padding is cosmetic and carries no functional risk, but the src/components/Medicine/FormattedDosage.tsx — consider whether Important Files Changed
Reviews (1): Last reviewed commit: "fix: remove unnecessary padding from dos..." | Re-trigger Greptile |
| <span | ||
| className={cn( | ||
| "rounded bg-yellow-100 px-1.5 py-0.5 font-semibold text-yellow-900", | ||
| "rounded bg-yellow-100 font-semibold text-yellow-900", |
There was a problem hiding this comment.
With
px-1.5 py-0.5 removed, there is no background extending beyond the text, so the rounded class has no visible effect. If the intent is a flat inline highlight with no padding, rounded can be dropped; if some padding is still desired (e.g., just horizontal), the padding values can be adjusted rather than fully removed.
| "rounded bg-yellow-100 font-semibold text-yellow-900", | |
| "bg-yellow-100 font-semibold text-yellow-900", |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
🎭 Playwright Test ResultsStatus: ✅ Passed
📊 Detailed results are available in the playwright-final-report artifact. Run: #10256 |
Proposed Changes
Fixes #issue_number
Tagging: @ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit